feat(starknet_os): implement hint store_da_segment

[dorimedini-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[dorimedini-starkware]

• feat(starknet_os): use ark_poly FFT implementation #4985
• feat(starknet_os): inline ark_poly bit_reversal algorithm #5110
• test(starknet_os): fft regression #4984
• feat(starknet_os): use BigUint instead of BigInt in KZG area #4922
• refactor(starknet_os): inner_fft implementation without cloning the slices #4896
• test(starknet_os): add small fft regression test #4895
• feat(starknet_os): implement hint store_da_segment #4880 👈 (View in Graphite)
• feat(starknet_os): add the da_segment field to the hint processor #4879
• feat(starknet_os): integrate polynomial_coefficients_to_kzg_commitment #4878
• feat(starknet_os): integrate split_commitment and test #4877
• feat(starknet_os): integrate blob_to_kzg_commitment and add trusted setup data #4876
• feat(starknet_os): integrate polynomial_coefficients_to_blob #4875
• feat(starknet_os): integrate to_bytes and serialize_blob #4874
• feat(starknet_os): integrate the fft function #4873
• feat(starknet_os): integrate the inner_fft function #4872
• feat(starknet_os): split KZG module into implementation and utils #4871
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[aner-starkware]

Reviewed 5 of 5 files at r5, 5 of 5 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware, @dorimedini-starkware, and @nimrod-starkware)

[dorimedini-starkware]

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @amosStarkware, @aner-starkware, and @nimrod-starkware)

---

crates/starknet_os/src/hints/hint_implementation/kzg/implementation.rs line 42 at r4 (raw file):

Previously, aner-starkware wrote…

This double conversion doesn't seem to be the most efficient way; maybe we can write a tailored conversion for this specific case?

this would require implementing a custom conversion on Felt, which is out of our repo, so I'm against it; this is also a single conversion operation so the performance impact is negligible

---

crates/starknet_os/src/hints/hint_implementation/kzg/implementation.rs line 57 at r4 (raw file):

Previously, aner-starkware wrote…

Not about the log, about the types and the conversion.

ah, I see we can convert to Felts directly in polynomial_coefficients_to_kzg_commitment.
done.
(BigUint is added here at the top of the stack)

[aner-starkware]

Reviewed 5 of 5 files at r7, 5 of 5 files at r8, 3 of 3 files at r9, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware and @nimrod-starkware)

[aner-starkware]

Reviewed 3 of 5 files at r11, 3 of 3 files at r12, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware and @nimrod-starkware)

[aner-starkware]

Reviewed 6 of 6 files at r13, 5 of 5 files at r14, 3 of 3 files at r15, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware and @nimrod-starkware)

[aner-starkware]

Reviewed 6 of 6 files at r16, 5 of 5 files at r17, 3 of 3 files at r18, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware and @nimrod-starkware)