Skip to content

feat(starknet_os): integrate polynomial_coefficients_to_blob #4875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@dorimedini-starkware dorimedini-starkware self-assigned this Mar 12, 2025
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review March 12, 2025 17:22
@dorimedini-starkware dorimedini-starkware force-pushed the 03-12-feat_starknet_os_integrate_to_bytes_and_serialize_blob branch from d84fbbe to b531874 Compare March 12, 2025 17:44
@dorimedini-starkware dorimedini-starkware force-pushed the 03-12-feat_starknet_os_integrate_polynomial_coefficients_to_blob branch from beb3948 to 683e483 Compare March 12, 2025 17:44
@dorimedini-starkware dorimedini-starkware force-pushed the 03-12-feat_starknet_os_integrate_to_bytes_and_serialize_blob branch from b531874 to 95496a1 Compare March 12, 2025 18:04
@dorimedini-starkware dorimedini-starkware force-pushed the 03-12-feat_starknet_os_integrate_polynomial_coefficients_to_blob branch from 683e483 to 6504640 Compare March 12, 2025 18:04
@dorimedini-starkware dorimedini-starkware force-pushed the 03-12-feat_starknet_os_integrate_to_bytes_and_serialize_blob branch from 95496a1 to cf4d3aa Compare March 13, 2025 08:46
@dorimedini-starkware dorimedini-starkware force-pushed the 03-12-feat_starknet_os_integrate_polynomial_coefficients_to_blob branch from 6504640 to ba8ad0b Compare March 13, 2025 08:46
@dorimedini-starkware dorimedini-starkware force-pushed the 03-12-feat_starknet_os_integrate_to_bytes_and_serialize_blob branch from cf4d3aa to f480f1f Compare March 13, 2025 09:30
@dorimedini-starkware dorimedini-starkware force-pushed the 03-12-feat_starknet_os_integrate_polynomial_coefficients_to_blob branch from ba8ad0b to 1e43e67 Compare March 13, 2025 09:30
@dorimedini-starkware dorimedini-starkware force-pushed the 03-12-feat_starknet_os_integrate_to_bytes_and_serialize_blob branch from f480f1f to 2397b8f Compare March 13, 2025 09:33
@dorimedini-starkware dorimedini-starkware force-pushed the 03-12-feat_starknet_os_integrate_polynomial_coefficients_to_blob branch from 1e43e67 to 5c01637 Compare March 13, 2025 09:33
Copy link
Contributor

@aner-starkware aner-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @amosStarkware and @nimrod-starkware)


crates/starknet_os/src/hints/hint_implementation/kzg/utils.rs line 154 at r2 (raw file):

    let prime = BigInt::from_str_radix(BLS_PRIME, 10)?;
    let bit_reversed = true;
    let fft_result = fft(&padded_coefficients, &generator, &prime, bit_reversed)?;

Add logs to check fft runtime.

Code quote:

    // Perform FFT on the coefficients
    let generator = BigInt::from_str_radix(BLOB_SUBGROUP_GENERATOR, 10)?;
    let prime = BigInt::from_str_radix(BLS_PRIME, 10)?;
    let bit_reversed = true;
    let fft_result = fft(&padded_coefficients, &generator, &prime, bit_reversed)?;

Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @amosStarkware, @aner-starkware, and @nimrod-starkware)


crates/starknet_os/src/hints/hint_implementation/kzg/utils.rs line 154 at r2 (raw file):

Previously, aner-starkware wrote…

Add logs to check fft runtime.

done, at the top of the stack (I prefer to keep debug logs inside the hint implementation functions themselves)

@dorimedini-starkware dorimedini-starkware force-pushed the 03-12-feat_starknet_os_integrate_to_bytes_and_serialize_blob branch from 2397b8f to 2888410 Compare March 13, 2025 11:41
@dorimedini-starkware dorimedini-starkware force-pushed the 03-12-feat_starknet_os_integrate_polynomial_coefficients_to_blob branch from 5c01637 to 4337de6 Compare March 13, 2025 11:41
@dorimedini-starkware dorimedini-starkware force-pushed the 03-12-feat_starknet_os_integrate_polynomial_coefficients_to_blob branch from 4337de6 to 08687bf Compare March 13, 2025 13:35
@dorimedini-starkware dorimedini-starkware force-pushed the 03-12-feat_starknet_os_integrate_to_bytes_and_serialize_blob branch from 65ce4e3 to ed9a6a8 Compare March 13, 2025 13:50
@dorimedini-starkware dorimedini-starkware force-pushed the 03-12-feat_starknet_os_integrate_polynomial_coefficients_to_blob branch from 08687bf to dfa72d2 Compare March 13, 2025 13:50
Copy link
Contributor

@aner-starkware aner-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware and @nimrod-starkware)

@dorimedini-starkware dorimedini-starkware force-pushed the 03-12-feat_starknet_os_integrate_to_bytes_and_serialize_blob branch from ed9a6a8 to 483fa50 Compare March 16, 2025 09:36
@dorimedini-starkware dorimedini-starkware force-pushed the 03-12-feat_starknet_os_integrate_polynomial_coefficients_to_blob branch from dfa72d2 to 1a63f40 Compare March 16, 2025 09:36
@dorimedini-starkware dorimedini-starkware force-pushed the 03-12-feat_starknet_os_integrate_to_bytes_and_serialize_blob branch from 483fa50 to 07d1edc Compare March 16, 2025 09:55
@dorimedini-starkware dorimedini-starkware force-pushed the 03-12-feat_starknet_os_integrate_polynomial_coefficients_to_blob branch from 1a63f40 to 6675437 Compare March 16, 2025 09:55
Copy link
Contributor

@aner-starkware aner-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware and @nimrod-starkware)

@dorimedini-starkware dorimedini-starkware force-pushed the 03-12-feat_starknet_os_integrate_to_bytes_and_serialize_blob branch from 07d1edc to 3cc91e4 Compare March 16, 2025 14:08
@dorimedini-starkware dorimedini-starkware force-pushed the 03-12-feat_starknet_os_integrate_polynomial_coefficients_to_blob branch from 6675437 to 4987062 Compare March 16, 2025 14:08
@dorimedini-starkware dorimedini-starkware force-pushed the 03-12-feat_starknet_os_integrate_to_bytes_and_serialize_blob branch from 3cc91e4 to 9670309 Compare March 16, 2025 16:16
@dorimedini-starkware dorimedini-starkware force-pushed the 03-12-feat_starknet_os_integrate_polynomial_coefficients_to_blob branch from 4987062 to 52019b0 Compare March 16, 2025 16:16
@dorimedini-starkware dorimedini-starkware force-pushed the 03-12-feat_starknet_os_integrate_to_bytes_and_serialize_blob branch from 9670309 to 1b98475 Compare March 17, 2025 08:20
@dorimedini-starkware dorimedini-starkware force-pushed the 03-12-feat_starknet_os_integrate_polynomial_coefficients_to_blob branch from 52019b0 to f46d2ec Compare March 17, 2025 08:20
@dorimedini-starkware dorimedini-starkware force-pushed the 03-12-feat_starknet_os_integrate_to_bytes_and_serialize_blob branch from 1b98475 to ae26527 Compare March 17, 2025 15:24
@dorimedini-starkware dorimedini-starkware force-pushed the 03-12-feat_starknet_os_integrate_polynomial_coefficients_to_blob branch from f46d2ec to 2b4d484 Compare March 17, 2025 15:24
Copy link
Contributor

@aner-starkware aner-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r6, 1 of 1 files at r7, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware and @nimrod-starkware)

@dorimedini-starkware dorimedini-starkware force-pushed the 03-12-feat_starknet_os_integrate_to_bytes_and_serialize_blob branch from ae26527 to a282a52 Compare March 17, 2025 16:25
Signed-off-by: Dori Medini <dori@starkware.co>
Signed-off-by: Dori Medini <dori@starkware.co>
@dorimedini-starkware dorimedini-starkware force-pushed the 03-12-feat_starknet_os_integrate_polynomial_coefficients_to_blob branch from 2b4d484 to 6fa1683 Compare March 17, 2025 17:59
@dorimedini-starkware dorimedini-starkware changed the base branch from 03-12-feat_starknet_os_integrate_to_bytes_and_serialize_blob to main March 17, 2025 17:59
@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Mar 17, 2025
Merged via the queue into main with commit 7a2517d Mar 17, 2025
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants