-
Notifications
You must be signed in to change notification settings - Fork 52
feat(starknet_os): integrate polynomial_coefficients_to_blob #4875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(starknet_os): integrate polynomial_coefficients_to_blob #4875
Conversation
d84fbbe
to
b531874
Compare
beb3948
to
683e483
Compare
b531874
to
95496a1
Compare
683e483
to
6504640
Compare
95496a1
to
cf4d3aa
Compare
6504640
to
ba8ad0b
Compare
cf4d3aa
to
f480f1f
Compare
ba8ad0b
to
1e43e67
Compare
f480f1f
to
2397b8f
Compare
1e43e67
to
5c01637
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @amosStarkware and @nimrod-starkware)
crates/starknet_os/src/hints/hint_implementation/kzg/utils.rs
line 154 at r2 (raw file):
let prime = BigInt::from_str_radix(BLS_PRIME, 10)?; let bit_reversed = true; let fft_result = fft(&padded_coefficients, &generator, &prime, bit_reversed)?;
Add logs to check fft
runtime.
Code quote:
// Perform FFT on the coefficients
let generator = BigInt::from_str_radix(BLOB_SUBGROUP_GENERATOR, 10)?;
let prime = BigInt::from_str_radix(BLS_PRIME, 10)?;
let bit_reversed = true;
let fft_result = fft(&padded_coefficients, &generator, &prime, bit_reversed)?;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @amosStarkware, @aner-starkware, and @nimrod-starkware)
crates/starknet_os/src/hints/hint_implementation/kzg/utils.rs
line 154 at r2 (raw file):
Previously, aner-starkware wrote…
Add logs to check
fft
runtime.
done, at the top of the stack (I prefer to keep debug logs inside the hint implementation functions themselves)
2397b8f
to
2888410
Compare
5c01637
to
4337de6
Compare
4337de6
to
08687bf
Compare
65ce4e3
to
ed9a6a8
Compare
08687bf
to
dfa72d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @amosStarkware and @nimrod-starkware)
ed9a6a8
to
483fa50
Compare
dfa72d2
to
1a63f40
Compare
483fa50
to
07d1edc
Compare
1a63f40
to
6675437
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @amosStarkware and @nimrod-starkware)
07d1edc
to
3cc91e4
Compare
6675437
to
4987062
Compare
3cc91e4
to
9670309
Compare
4987062
to
52019b0
Compare
9670309
to
1b98475
Compare
52019b0
to
f46d2ec
Compare
1b98475
to
ae26527
Compare
f46d2ec
to
2b4d484
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r6, 1 of 1 files at r7, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @amosStarkware and @nimrod-starkware)
ae26527
to
a282a52
Compare
Signed-off-by: Dori Medini <dori@starkware.co>
Signed-off-by: Dori Medini <dori@starkware.co>
2b4d484
to
6fa1683
Compare
No description provided.