feat(DAI withdrawals): call increaseAllowance before calling initiate_withdraw
#200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-ziv
changed the title
increaseAllowance before calling initiate_withdrawincreaseAllowance before calling initiate_withdraw
dan-ziv
changed the title
increaseAllowance before calling initiate_withdrawincreaseAllowance before calling initiate_withdraw
dan-ziv
suggested changes
May 24, 2022
dan-ziv
suggested changes
May 24, 2022
dan-ziv
approved these changes
May 25, 2022
dan-ziv
pushed a commit
that referenced
this pull request
May 25, 2022
## [1.5.0-dev.14](v1.5.0-dev.13...v1.5.0-dev.14) (2022-05-25) ### 🧩 Features * **DAI withdrawals:** call `increaseAllowance` before calling `initiate_withdraw` ([#200](#200)) ([7a2c284](7a2c284))
|
🎉 This PR is included in version 1.5.0-dev.14 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
dan-ziv
pushed a commit
that referenced
this pull request
May 26, 2022
## [1.5.0](v1.4.0...v1.5.0) (2022-05-26) ### 🧩 Features * add LayerSwap to liquidity providers ([#201](#201)) ([4f8aa97](4f8aa97)) * buy into L2 (fiat on ramp) + Banxa provider ([#183](#183)) ([6df9b4d](6df9b4d)) * **DAI withdrawals:** call `increaseAllowance` before calling `initiate_withdraw` ([#200](#200)) ([7a2c284](7a2c284)) * lock bridge ([#198](#198)) ([4f433e6](4f433e6)) * move Terms and FAQ routes to burger menu ([#202](#202)) ([264b550](264b550)) * move the discord tab to a side button ([#199](#199)) ([0570a92](0570a92)) * MultiChoiceMenu component ([#181](#181)) ([bbf19ba](bbf19ba)) ### 💉 Improvements * export convention ([#180](#180)) ([b5585ad](b5585ad)) * promise handler instead of try/catch statement ([#209](#209)) ([1f56c38](1f56c38)) * terms screen ([#207](#207)) ([0feca18](0feca18)) * tokens addresses ([#178](#178)) ([c75a88a](c75a88a)) ### 🔧 Fixes * change transfer tabs names ([#182](#182)) ([e795f1c](e795f1c)) * CompleteTransferToL1 toast remains on display after tx is done ([#179](#179)) ([219b860](219b860)) * **GATE-2:** change documentation links on FAQ page ([#206](#206)) ([ec0741a](ec0741a)) * **GATE-5:** "Transfer in progress" popup doesn't close even after transaction is successful ([#210](#210)) ([4e11653](4e11653)) * **GATE-7:** Call 'ceiling' on DAI bridge instead of 'maxTotalBalance' ([#196](#196)) ([50a2780](50a2780)) * **GATE-9:** incorrect DAI amount ([#208](#208)) ([46b80bd](46b80bd)) * handle Discord button on scroll ([#205](#205)) ([5fdce7e](5fdce7e)) * **Header:** testnet title not displayed ([4169584](4169584)) * modal error messages not displayed ([#194](#194)) ([353c3b4](353c3b4)) * move EventManagerProvider to app-level ([#197](#197)) ([7fbd4fe](7fbd4fe))
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is