Skip to content

Conversation

dan-ziv
Copy link

@dan-ziv dan-ziv commented May 4, 2022

Description of the Changes

Currently tokens addresses are represented as a key-value object to map the address to its chain:

bridgeAddress: {
  MAINNET_CHAIN_ID : '0x...',
  GOERLI_CHAIN_ID : '0x...'
},
tokenAddress: {
  MAINNET_CHAIN_ID: '0x...',
  GOERLI_CHAIN_ID : '0x...'
}

When the app is up we know the chain we're working with, so no need for this mapping.
Use simple map as address: string.

Checklist

  • Changes have been done against master branch, and PR does not conflict
  • New unit / functional tests have been added (whenever applicable)
  • Test are passing in local environment
  • Docs have been updated
  • PR title is follow the Conventional Commits convention: <type>[optional scope]: <description>, e.g: fix: prevent racing of requests

This change is Reviewable

@dan-ziv dan-ziv merged commit c75a88a into dev May 10, 2022
@dan-ziv dan-ziv deleted the refactor/tokens branch May 10, 2022 12:57
dan-ziv pushed a commit that referenced this pull request May 10, 2022
 ### [1.4.2-dev.2](v1.4.2-dev.1...v1.4.2-dev.2) (2022-05-10)

### 💉 Improvements

* tokens addresses ([#178](#178)) ([c75a88a](c75a88a))
@dan-ziv
Copy link
Author

dan-ziv commented May 10, 2022

🎉 This PR is included in version 1.4.2-dev.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

dan-ziv pushed a commit that referenced this pull request May 26, 2022
 ## [1.5.0](v1.4.0...v1.5.0) (2022-05-26)

### 🧩 Features

* add LayerSwap to liquidity providers ([#201](#201)) ([4f8aa97](4f8aa97))
* buy into L2 (fiat on ramp) + Banxa provider  ([#183](#183)) ([6df9b4d](6df9b4d))
* **DAI withdrawals:** call `increaseAllowance` before calling `initiate_withdraw` ([#200](#200)) ([7a2c284](7a2c284))
* lock bridge ([#198](#198)) ([4f433e6](4f433e6))
* move Terms and FAQ routes to burger menu ([#202](#202)) ([264b550](264b550))
* move the discord tab to a side button ([#199](#199)) ([0570a92](0570a92))
* MultiChoiceMenu component ([#181](#181)) ([bbf19ba](bbf19ba))

### 💉 Improvements

* export convention ([#180](#180)) ([b5585ad](b5585ad))
* promise handler instead of try/catch statement ([#209](#209)) ([1f56c38](1f56c38))
* terms screen ([#207](#207)) ([0feca18](0feca18))
* tokens addresses ([#178](#178)) ([c75a88a](c75a88a))

### 🔧 Fixes

* change transfer tabs names ([#182](#182)) ([e795f1c](e795f1c))
* CompleteTransferToL1 toast remains on display after tx is done ([#179](#179)) ([219b860](219b860))
* **GATE-2:** change documentation links on FAQ page ([#206](#206)) ([ec0741a](ec0741a))
* **GATE-5:** "Transfer in progress" popup doesn't close even after transaction is successful ([#210](#210)) ([4e11653](4e11653))
* **GATE-7:** Call 'ceiling' on DAI bridge instead of 'maxTotalBalance' ([#196](#196)) ([50a2780](50a2780))
* **GATE-9:** incorrect DAI amount ([#208](#208)) ([46b80bd](46b80bd))
* handle Discord button on scroll ([#205](#205)) ([5fdce7e](5fdce7e))
* **Header:** testnet title not displayed ([4169584](4169584))
* modal error messages not displayed ([#194](#194)) ([353c3b4](353c3b4))
* move EventManagerProvider to app-level ([#197](#197)) ([7fbd4fe](7fbd4fe))
@dan-ziv
Copy link
Author

dan-ziv commented May 26, 2022

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant