Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance(datastore): tune datastore storage dir by swcli config #902

Merged
merged 1 commit into from
Aug 11, 2022
Merged

enhance(datastore): tune datastore storage dir by swcli config #902

merged 1 commit into from
Aug 11, 2022

Conversation

tianweidut
Copy link
Member

Description

  • replace SW_ROOT_PATH env with SWCliConfigMixed class for fetching datastore dir
  • patch atexit in test

Modules

  • Python-SDK

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added this to the v0.3 milestone Aug 11, 2022
@tianweidut tianweidut self-assigned this Aug 11, 2022
@tianweidut tianweidut force-pushed the enhance/update-datastore-dir branch 4 times, most recently from fa75c08 to b95e43d Compare August 11, 2022 08:15
xuchuan
xuchuan approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@xuchuan xuchuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xuchuan xuchuan force-pushed the enhance/update-datastore-dir branch from b95e43d to 8553c14 Compare August 11, 2022 10:49
@xuchuan xuchuan merged commit 52cafb9 into star-whale:main Aug 11, 2022
@tianweidut tianweidut mentioned this pull request Aug 15, 2022
Merged
9 tasks
@tianweidut tianweidut deleted the enhance/update-datastore-dir branch April 16, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuchuan xuchuan xuchuan approved these changes

@jialeicui jialeicui Awaiting requested review from jialeicui

@goldenxinxing goldenxinxing Awaiting requested review from goldenxinxing

Assignees

@tianweidut tianweidut

Labels
datastore 🐇 enhancement ❤️ New feature or request sdk 🐶
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tianweidut @xuchuan