Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(job): custom job scheduler #880

Merged
merged 119 commits into from
Aug 18, 2022
Merged

feat(job): custom job scheduler #880

merged 119 commits into from
Aug 18, 2022

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Aug 8, 2022 •
edited
Loading

Description

  1. change cmd: swcli job create to swcli eval run
    image
    image

  2. change cmd: swcli model ppl/cmp {target} to swcli model eval {target} --step **

  3. add feature: job scheduler(@step\default_ppl_handler)
    image

Use case mnist compared to the original implementation（No other changes）:
image

  1. docker entrypoint use new cmd：swcli model eval {target} --step **

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

goldenxinxing and others added 30 commits August 2, 2022 15:17
@goldenxinxing
draft new job scheduler
c72ce28
@goldenxinxing
tune example for mnist
adada06
update mnist model file
0832876
refactor(eval):job dag
5d3d41e
fix yaml dump problem
c2f7653
run eval with existing version; single task execute
7522875
dataset uri sent by param
53fa451
optimise entrypoint
58c9402
@goldenxinxing
code format
d8d9c3a
feat:add default handler for evaluation
9849301
update ignore
e7c2408
add default handler for eval
d1db3fd
change job values to list
78a51e4
job parser for controller
525ad32
job parser for controller
594439e
controller:extract job content during upload;tune task entity(doing)
639ce3f
change eval handler to model
f867dd7
change eval handler to model
23a2f76
default pipeline use datastore(doing)
c42f496
@goldenxinxing
draft new job scheduler
236ffb9
@goldenxinxing
tune example for mnist
40fec7c
model change
8c5c5d5
refactor(eval):job dag
0620c74
fix yaml dump problem
47beade
run eval with existing version; single task execute
18cc832
dataset uri sent by param
0ed6e20
optimise entrypoint
011c583
@goldenxinxing
code format
d626837
feat:add default handler for evaluation
22ddec6
update ignore
9f49100
tianweidut
tianweidut previously approved these changes Aug 18, 2022
View reviewed changes
@tianweidut tianweidut self-requested a review August 18, 2022 06:55
@tianweidut tianweidut self-requested a review August 18, 2022 07:14
tianweidut
tianweidut approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut self-requested a review August 18, 2022 09:11
@tianweidut tianweidut merged commit 5d2cdfe into star-whale:main Aug 18, 2022
@goldenxinxing goldenxinxing deleted the feat/job_3 branch August 25, 2022 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianweidut tianweidut tianweidut approved these changes

@anda-ren anda-ren Awaiting requested review from anda-ren

@jialeicui jialeicui Awaiting requested review from jialeicui

@xuchuan xuchuan Awaiting requested review from xuchuan

Assignees

@goldenxinxing goldenxinxing

Labels
break-change 💔 break change client 🌈 controller 🏘️ feature ✨ new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goldenxinxing @tianweidut