Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SDK): support argument for model run #3095

Merged
merged 3 commits into from
Dec 29, 2023

Conversation

tianweidut
Copy link
Member

@tianweidut tianweidut commented Dec 22, 2023

Description

the follow-up changes:

  • use @argument decor refactor handle-args
  • dump argument json for starwhale console when building model package
  • add --help output for the user custom arguments

Modules

  • Python-SDK

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut self-assigned this Dec 22, 2023
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (b7524b5) 82.68% compared to head (29175f3) 91.89%.
Report is 2 commits behind head on main.

Files Patch % Lines
client/starwhale/api/_impl/argument.py 94.69% 6 Missing ⚠️
client/starwhale/api/_impl/evaluation/pipeline.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3095      +/-   ##
============================================
+ Coverage     82.68%   91.89%   +9.20%     
============================================
  Files           573      139     -434     
  Lines         31970    16244   -15726     
  Branches       1865        0    -1865     
============================================
- Hits          26435    14927   -11508     
+ Misses         4709     1317    -3392     
+ Partials        826        0     -826     
Flag Coverage Δ
console ?
controller ?
standalone 91.89% <94.26%> (+<0.01%) ⬆️
unittests 91.89% <94.26%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit e6a498b into star-whale:main Dec 29, 2023
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants