Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): support backup and restore for mysql #1978

Merged

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Mar 16, 2023

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #1978 (4ec231e) into main (7b34adf) will decrease coverage by 8.87%.
The diff coverage is 79.67%.

@@             Coverage Diff              @@
##               main    #1978      +/-   ##
============================================
- Coverage     82.51%   73.65%   -8.87%     
- Complexity     2069     2091      +22     
============================================
  Files           387      293      -94     
  Lines         20676    10209   -10467     
  Branches       1122     1143      +21     
============================================
- Hits          17060     7519    -9541     
+ Misses         3104     2170     -934     
- Partials        512      520       +8     
Flag Coverage Δ
controller 73.65% <79.67%> (+0.10%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../starwhale/mlops/backup/db/MysqlBackupService.java 78.97% <78.97%> (ø)
...a/ai/starwhale/mlops/backup/db/TablesResponse.java 100.00% <100.00%> (ø)

... and 99 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

dreamlandliu
dreamlandliu previously approved these changes Mar 20, 2023
Copy link
Contributor

@dreamlandliu dreamlandliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@dreamlandliu dreamlandliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dreamlandliu dreamlandliu merged commit 096c04c into star-whale:main Mar 21, 2023
@goldenxinxing goldenxinxing deleted the feat/add_mariadb_backup_and_restore branch April 27, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ✨ new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants