add check

star-whale · Mar 20, 2023 · 4ec231e · 4ec231e
1 parent 71b955d
commit 4ec231e
Showing 1 changed file with 13 additions and 9 deletions.
diff --git a/server/controller/src/main/java/ai/starwhale/mlops/backup/db/MysqlBackupService.java b/server/controller/src/main/java/ai/starwhale/mlops/backup/db/MysqlBackupService.java
@@ -56,18 +56,22 @@ private static Connection doConnect(String driver, String url, String username,
     }
 
     public static String extractDatabaseFromUrl(String url) {
-        if (url == null || url.isEmpty()) {
-            throw new RuntimeException("Null or Empty JDBC URL supplied: " + url);
+        if (!hasDatabase(url)) {
+            throw new RuntimeException("Invalid JDBC URL supplied: " + url);
         }
+        return url.substring(url.lastIndexOf("/") + 1, url.indexOf("?"));
+    }
 
-        String urlWithoutParams;
-        if (url.contains("?")) {
-            urlWithoutParams = url.substring(0, url.indexOf("?"));
-        } else {
-            urlWithoutParams = url;
+    public static boolean hasDatabase(String url) {
+        if (url == null || url.isEmpty()) {
+            return false;
         }
-
-        return urlWithoutParams.substring(urlWithoutParams.lastIndexOf("/") + 1);
+        int index = url.indexOf("://");
+        if (index == -1) {
+            return false;
+        }
+        index = url.indexOf("/", index + 3);
+        return index != -1;
     }
 
     private static TablesResponse getAllTablesAndViews(Statement statement, String database) throws SQLException {