Skip to content

Conversation

@jacinta-stacks
Copy link
Contributor

Replaces #6608

@jacinta-stacks jacinta-stacks force-pushed the feat/expand-consensus-test-to-support-pre-nakamoto-epochs branch from 86e4e60 to 58cee2e Compare October 22, 2025 21:24
@CLAassistant
Copy link

CLAassistant commented Oct 22, 2025

CLA assistant check
All committers have signed the CLA.

@jacinta-stacks jacinta-stacks force-pushed the feat/expand-consensus-test-to-support-pre-nakamoto-epochs branch 5 times, most recently from c3a3c2f to c6ce521 Compare October 22, 2025 23:22
Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
@jacinta-stacks jacinta-stacks force-pushed the feat/expand-consensus-test-to-support-pre-nakamoto-epochs branch from c6ce521 to 1eb48de Compare October 27, 2025 16:21
… into feat/expand-consensus-test-to-support-pre-nakamoto-epochs
Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
… into feat/expand-consensus-test-to-support-pre-nakamoto-epochs
Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
…t to use all epochs GTE epoch 2.0

Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
… into feat/expand-consensus-test-to-support-pre-nakamoto-epochs
@jacinta-stacks jacinta-stacks marked this pull request as ready for review October 28, 2025 22:13
@jacinta-stacks jacinta-stacks requested review from a team as code owners October 28, 2025 22:13
@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 91.81970% with 98 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.80%. Comparing base (dc555b4) to head (8c55ee7).
⚠️ Report is 33 commits behind head on develop.

Files with missing lines Patch % Lines
stackslib/src/chainstate/tests/consensus.rs 94.88% 30 Missing ⚠️
stackslib/src/core/mod.rs 66.66% 19 Missing ⚠️
stacks-node/src/tests/epoch_21.rs 0.00% 16 Missing ⚠️
...-node/src/burnchains/bitcoin_regtest_controller.rs 0.00% 8 Missing ⚠️
stackslib/src/chainstate/coordinator/mod.rs 0.00% 7 Missing ⚠️
stacks-node/src/tests/epoch_205.rs 0.00% 6 Missing ⚠️
stackslib/src/chainstate/nakamoto/tests/node.rs 89.09% 6 Missing ⚠️
stackslib/src/chainstate/tests/mod.rs 99.03% 4 Missing ⚠️
...ackslib/src/chainstate/nakamoto/coordinator/mod.rs 71.42% 2 Missing ⚠️

❌ Your project status has failed because the head coverage (76.80%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6619       +/-   ##
============================================
+ Coverage    64.38%   76.80%   +12.42%     
============================================
  Files          575      575               
  Lines       355807   356406      +599     
============================================
+ Hits        229097   273753    +44656     
+ Misses      126710    82653    -44057     
Files with missing lines Coverage Δ
stacks-common/src/types/mod.rs 74.63% <100.00%> (-0.42%) ⬇️
...kslib/src/chainstate/nakamoto/coordinator/tests.rs 99.50% <100.00%> (+8.89%) ⬆️
stackslib/src/config/mod.rs 68.00% <100.00%> (+6.36%) ⬆️
stackslib/src/net/tests/mod.rs 95.78% <100.00%> (+11.15%) ⬆️
...ackslib/src/chainstate/nakamoto/coordinator/mod.rs 80.40% <71.42%> (-1.12%) ⬇️
stackslib/src/chainstate/tests/mod.rs 77.37% <99.03%> (+7.26%) ⬆️
stacks-node/src/tests/epoch_205.rs 0.00% <0.00%> (ø)
stackslib/src/chainstate/nakamoto/tests/node.rs 84.02% <89.09%> (+0.16%) ⬆️
stackslib/src/chainstate/coordinator/mod.rs 75.21% <0.00%> (-3.47%) ⬇️
...-node/src/burnchains/bitcoin_regtest_controller.rs 65.20% <0.00%> (+7.98%) ⬆️
... and 3 more

... and 368 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc555b4...8c55ee7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@francesco-stacks francesco-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still need to finish the review of the changes in the consensus.rs file, but GREAT work!

… into feat/expand-consensus-test-to-support-pre-nakamoto-epochs
…ion handling pre epoch 2.0

Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
… into feat/expand-consensus-test-to-support-pre-nakamoto-epochs
@jacinta-stacks jacinta-stacks force-pushed the feat/expand-consensus-test-to-support-pre-nakamoto-epochs branch from 1ea1f63 to b299a8c Compare November 5, 2025 03:18
….0 reward set calculation rules apply

Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
@wileyj
Copy link
Collaborator

wileyj commented Nov 5, 2025 via email

@jacinta-stacks jacinta-stacks force-pushed the feat/expand-consensus-test-to-support-pre-nakamoto-epochs branch from 5b2bf92 to 52fc4c4 Compare November 5, 2025 23:49
Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
Copy link
Contributor

@federico-stacks federico-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt!

waiting for integration test ci-process being fixed before final approval!

Copy link
Contributor

@aaronb-stacks aaronb-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just had one question about the handling of runtime errors in the expected output struct.

aaronb-stacks
aaronb-stacks previously approved these changes Nov 11, 2025
… into feat/expand-consensus-test-to-support-pre-nakamoto-epochs
@jacinta-stacks
Copy link
Contributor Author

jacinta-stacks commented Nov 11, 2025

Looking into failing tests. These are def related to my assertions change on reward cycle setup.

Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
… into feat/expand-consensus-test-to-support-pre-nakamoto-epochs
@jacinta-stacks jacinta-stacks added this pull request to the merge queue Nov 12, 2025
Merged via the queue into stacks-network:develop with commit ebc8fb0 Nov 12, 2025
307 of 312 checks passed
@jacinta-stacks jacinta-stacks deleted the feat/expand-consensus-test-to-support-pre-nakamoto-epochs branch November 12, 2025 20:00
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants