Skip to content

Conversation

@jferrant
Copy link
Contributor

@jferrant jferrant commented Oct 16, 2025

Still need to dymanically create the epoch list to have epochs large enough to support the number of blocks in pre nakamoto epochs we want to run.

@jferrant jferrant force-pushed the feat/expand-consensus-test-to-support-pre-nakamoto-epochs branch 3 times, most recently from 4030aea to 0b0581b Compare October 20, 2025 23:08
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
@jferrant jferrant force-pushed the feat/expand-consensus-test-to-support-pre-nakamoto-epochs branch from 0b0581b to 5f6b3e7 Compare October 21, 2025 21:57
@jferrant jferrant changed the title WIP: Update chainstate to work on pre nakamoto epochs. Update chainstate to work on pre nakamoto epochs. Oct 21, 2025
@jferrant jferrant marked this pull request as ready for review October 21, 2025 21:58
@jferrant jferrant requested review from a team as code owners October 21, 2025 21:58
@jacinta-stacks jacinta-stacks marked this pull request as draft October 22, 2025 02:04
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 17.19858% with 467 lines in your changes missing coverage. Please review.
✅ Project coverage is 31.87%. Comparing base (f4787ad) to head (5f6b3e7).
⚠️ Report is 15 commits behind head on develop.

Files with missing lines Patch % Lines
stackslib/src/chainstate/tests/mod.rs 21.39% 327 Missing ⚠️
stackslib/src/chainstate/tests/consensus.rs 0.00% 72 Missing ⚠️
stackslib/src/chainstate/nakamoto/tests/node.rs 0.00% 55 Missing ⚠️
stackslib/src/chainstate/coordinator/mod.rs 0.00% 7 Missing ⚠️
stackslib/src/net/tests/mod.rs 33.33% 6 Missing ⚠️

❌ Your project status has failed because the head coverage (31.87%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6608       +/-   ##
============================================
- Coverage    79.72%   31.87%   -47.85%     
============================================
  Files          571      571               
  Lines       351586   352028      +442     
============================================
- Hits        280293   112214   -168079     
- Misses       71293   239814   +168521     
Files with missing lines Coverage Δ
...ackslib/src/chainstate/nakamoto/coordinator/mod.rs 81.97% <100.00%> (-0.41%) ⬇️
stackslib/src/net/tests/mod.rs 31.82% <33.33%> (-66.65%) ⬇️
stackslib/src/chainstate/coordinator/mod.rs 70.68% <0.00%> (-10.06%) ⬇️
stackslib/src/chainstate/nakamoto/tests/node.rs 62.69% <0.00%> (-21.15%) ⬇️
stackslib/src/chainstate/tests/consensus.rs 0.00% <0.00%> (-94.85%) ⬇️
stackslib/src/chainstate/tests/mod.rs 48.56% <21.39%> (-21.52%) ⬇️

... and 509 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4787ad...5f6b3e7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants