Skip to content

Conversation

ASuciuX
Copy link
Contributor

@ASuciuX ASuciuX commented Mar 26, 2024

Description

Fixes CI mutants by skipping them and adding TODO for tests where is the case. This applies to PR 4483
with this summary of mutants. Even though the PR is not to be merged now, from its run those functions were highlighted and it is recommended to note them.

Applicable issues

Additional info (benefits, drawbacks, caveats)

  • On the following ci runs, will not rerun mutants for those functions as they are marked as skipped. We already know what the outcome is and how should they be treated so there is no need to waste extra CI time by rerunning them (in that PR or other PRs that modify those functions) .

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.93%. Comparing base (d0df9d1) to head (9d36bce).

Additional details and impacted files
@@             Coverage Diff             @@
##             next    #4593       +/-   ##
===========================================
- Coverage   83.36%   72.93%   -10.43%     
===========================================
  Files         470      465        -5     
  Lines      332151   330892     -1259     
  Branches      317        0      -317     
===========================================
- Hits       276905   241347    -35558     
- Misses      55238    89545    +34307     
+ Partials        8        0        -8     
Files Coverage Δ
clarity/src/vm/ast/traits_resolver/mod.rs 96.96% <ø> (-1.52%) ⬇️
clarity/src/vm/costs/mod.rs 80.76% <ø> (-1.09%) ⬇️
clarity/src/vm/types/mod.rs 86.29% <ø> (-5.12%) ⬇️

... and 225 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0df9d1...9d36bce. Read the comment docs.

@ASuciuX ASuciuX force-pushed the feat/track-mutants-clarity-contains-key branch from 245eeb2 to 9d97913 Compare March 27, 2024 12:38
@ASuciuX ASuciuX self-assigned this Mar 27, 2024
@ASuciuX ASuciuX requested review from a team and jbencin March 27, 2024 13:28
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saralab saralab requested a review from jcnelson March 29, 2024 14:12
@ASuciuX ASuciuX added this pull request to the merge queue Mar 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 29, 2024
@wileyj wileyj added this pull request to the merge queue Mar 29, 2024
Merged via the queue into stacks-network:next with commit 2686009 Mar 29, 2024
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants