Add skips and comments for certain mutants

[ASuciuX]

Related issue #4587

List of PRs addressed:

• Update StackStxOp to include signer key #4412
• Add cycle-id ranges to synthetic pox events #4414
• Fixes discovered while bringing up the pre-launch testnet #4527
• Chore: Remove Boxing of SymbolicExpressions #4530
• feat: add config parameters for burn block start #4556
• Add affirmation overrides config option and add default xenon ones ne… #4560
• Disable Microblocks in Epoch 2.5 #4561
• Merge develop into next #4575
• 2.5: PoX missed-slot updates #4576
• fix: allow nakamoto-neon mode #4578

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.18%. Comparing base (f9e9791) to head (dbacf43).
Report is 9 commits behind head on next.

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #4604      +/-   ##
==========================================
- Coverage   83.58%   83.18%   -0.41%     
==========================================
  Files         471      465       -6     
  Lines      337958   330892    -7066     
  Branches      317        0     -317     
==========================================
- Hits       282486   275248    -7238     
- Misses      55464    55644     +180     
+ Partials        8        0       -8     

Files	Coverage Δ
stackslib/src/burnchains/db.rs	80.64% <ø> (-0.02%)	⬇️
stackslib/src/burnchains/mod.rs	82.64% <ø> (-0.09%)	⬇️
stackslib/src/chainstate/burn/db/sortdb.rs	91.90% <ø> (-0.04%)	⬇️
stackslib/src/chainstate/coordinator/mod.rs	62.06% <ø> (-2.63%)	⬇️
stackslib/src/chainstate/stacks/boot/mod.rs	94.74% <ø> (-0.02%)	⬇️
stackslib/src/chainstate/stacks/db/blocks.rs	89.84% <ø> (-0.24%)	⬇️
stackslib/src/chainstate/stacks/miner.rs	81.43% <ø> (+0.27%)	⬆️
stackslib/src/main.rs	0.06% <ø> (ø)
...-node/src/burnchains/bitcoin_regtest_controller.rs	87.54% <ø> (-0.64%)	⬇️
testnet/stacks-node/src/config.rs	65.48% <ø> (-0.42%)	⬇️
... and 3 more

... and 355 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9e9791...dbacf43. Read the comment docs.

[ASuciuX]

This follows the same structure as #4593 which was previously merged. It includes the mutants for multiple PRs.

[jbencin]

I think the associated comments should be regular comments, not doc comments. cargo doc is great for figuring out how to use an API, and these comments don't help anyone actually use the functions

[ASuciuX]

I think the associated comments should be regular comments, not doc comments. cargo doc is great for figuring out how to use an API, and these comments don't help anyone actually use the functions

Those comments act as placeholders for missing tests, they should be reference for who wants to write the test cases that are in the comments and aren't treated by the functions. There should be something on the code to point to the specific missing cases so that a developer could know which test cases to add. Would it be enough to change them to simple comments instead of doc comments? Or do you think we should move them somewhere externally but also keep a short reference so that the cases can be seen when going to that external source. Also curious what that external source should be and how should I give access to the others to modify it if some of the tests are added.

[jbencin]

Would it be enough to change them to simple comments instead of doc comments?

This is fine by me. Although you should add a second reviewer on here for another opinion

[ASuciuX]

Would it be enough to change them to simple comments instead of doc comments?

This is fine by me. Although you should add a second reviewer on here for another opinion

I've added the blockchain team, but it treated your review in that behalf, so I'll add it again.

[ASuciuX]

@jbencin I've updated this to have regular comments

[ASuciuX]

As this is outdated and for next branch, I will move it to develop.

[ASuciuX]

Migrated the PR here #4790.

[blockstack-devops]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.