-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore]: use wrapper structs for heights #1448
Draft
MCJOHN974
wants to merge
12
commits into
main
Choose a base branch
from
viktar/heights-wrappers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whoa, during this PR, I first started with changing all heights from u64 to my structs everywhere in code. And now I have a couple of errors saying "you try to put Stacks height but expected Bitcoin height". And this is great, this mean this aliases are really useful! |
whoops, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WIP
Closes: #1405
Changes
Scope: refactoring was only in
signer
New dep: it is actually my code I wrote for this task, just was thinking for a while it can be useful to have it as a separate lib, with ability to reuse in other projects. However, I'm not sure if it can be useful after tried to use it (=. Anyway, if we do not want to add it as a dependency we can just move code from it to
sbtc
repo.Testing Information
Since it is small refactoring we do not need any new tests.
Checklist: