Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: use wrapper structs for heights #1448

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

MCJOHN974
Copy link
Collaborator

Description

WIP

Closes: #1405

Changes

Scope: refactoring was only in signer
New dep: it is actually my code I wrote for this task, just was thinking for a while it can be useful to have it as a separate lib, with ability to reuse in other projects. However, I'm not sure if it can be useful after tried to use it (=. Anyway, if we do not want to add it as a dependency we can just move code from it to sbtc repo.

Testing Information

Since it is small refactoring we do not need any new tests.

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@MCJOHN974 MCJOHN974 self-assigned this Mar 3, 2025
@MCJOHN974
Copy link
Collaborator Author

Whoa, during this PR, I first started with changing all heights from u64 to my structs everywhere in code. And now I have a couple of errors saying "you try to put Stacks height but expected Bitcoin height". And this is great, this mean this aliases are really useful!

@MCJOHN974
Copy link
Collaborator Author

whoops, sqlx don't actually work =(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Chore]: Use wrapper structs for bitcoin and stacks block height
1 participant