-
Notifications
You must be signed in to change notification settings - Fork 25
ROX-12735: add automation to enter new community PRs to OSS Triage board automatically #841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@tommartensen: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Although I'd be interested to know why so many tests failed for a workflow-related change.
@Maddosaurus, we kinda broke OSCI yesterday, sorry about that. We are working to get it back up and running and it is unrelated to these changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we unify this workflow with https://github.com/stackrox/collector/blob/master/.github/workflows/add-issue-to-triage.yml? Their goal seems to be pretty much the same, add issues/prs onto the OSS board.
@Molter73 - good idea, but while the goal is the same, we only want to add only external Pull Requests. The first job of this new workflow is the filter for that. We would need to implement another condition into that to distinguish between issues and PRs. I think it's cleaner to have separate actions for each type of input. |
You can ping me in the PR when I can rebase or re-run tests. Right now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@tommartensen you should be able to merge now, it was blocked because we require an approval from someone in the collector-team before merging. |
Description
New external PRs are labeled with
external-contributor
and added to the OSS Triage board.Tested in stackrox/dev-docs#17.
Checklist
[ ] Investigated and inspected CI test results[ ] Updated documentation accordinglyAutomated testing
[ ] Added unit tests[ ] Added integration tests[ ] Added regression testsIf any of these don't apply, please comment below.