Skip to content

ROX-12735: add automation to enter new community PRs to OSS Triage board automatically #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

tommartensen
Copy link
Contributor

Description

New external PRs are labeled with external-contributor and added to the OSS Triage board.
Tested in stackrox/dev-docs#17.

Checklist

  • [ ] Investigated and inspected CI test results
  • [ ] Updated documentation accordingly

Automated testing

  • [ ] Added unit tests
  • [ ] Added integration tests
  • [ ] Added regression tests

If any of these don't apply, please comment below.

@tommartensen tommartensen self-assigned this Sep 26, 2022
@tommartensen tommartensen requested a review from a team as a code owner September 26, 2022 18:16
@openshift-ci
Copy link

openshift-ci bot commented Sep 26, 2022

@tommartensen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test-scripts efd04a0 link true /test test-scripts
ci/prow/update-support-packages-from-registry efd04a0 link true /test update-support-packages-from-registry
ci/prow/push-drivers efd04a0 link false /test push-drivers
ci/prow/ubuntu-2204-lts-ebpf-integration-tests efd04a0 link true /test ubuntu-2204-lts-ebpf-integration-tests
ci/prow/ubuntu-pro-1804-lts-kernel-module-integration-tests efd04a0 link true /test ubuntu-pro-1804-lts-kernel-module-integration-tests
ci/prow/rhel-7-kernel-module-integration-tests efd04a0 link true /test rhel-7-kernel-module-integration-tests
ci/prow/ubuntu-2004-lts-ebpf-integration-tests efd04a0 link true /test ubuntu-2004-lts-ebpf-integration-tests
ci/prow/rhel-8-kernel-module-integration-tests efd04a0 link true /test rhel-8-kernel-module-integration-tests
ci/prow/ubuntu-2204-lts-kernel-module-integration-tests efd04a0 link true /test ubuntu-2204-lts-kernel-module-integration-tests
ci/prow/rhel-84-sap-ebpf-integration-tests efd04a0 link true /test rhel-84-sap-ebpf-integration-tests
ci/prow/ubuntu-1804-lts-kernel-module-integration-tests efd04a0 link true /test ubuntu-1804-lts-kernel-module-integration-tests
ci/prow/rhel-86-sap-kernel-module-integration-tests efd04a0 link true /test rhel-86-sap-kernel-module-integration-tests
ci/prow/rhel-8-ebpf-integration-tests efd04a0 link true /test rhel-8-ebpf-integration-tests
ci/prow/ubuntu-pro-1804-lts-ebpf-integration-tests efd04a0 link true /test ubuntu-pro-1804-lts-ebpf-integration-tests
ci/prow/rhel-86-sap-ebpf-integration-tests efd04a0 link true /test rhel-86-sap-ebpf-integration-tests
ci/prow/rhel-7-ebpf-integration-tests efd04a0 link true /test rhel-7-ebpf-integration-tests
ci/prow/ubuntu-1804-lts-ebpf-integration-tests efd04a0 link true /test ubuntu-1804-lts-ebpf-integration-tests
ci/prow/ubuntu-2004-lts-kernel-module-integration-tests efd04a0 link true /test ubuntu-2004-lts-kernel-module-integration-tests
ci/prow/rhel-84-sap-kernel-module-integration-tests efd04a0 link true /test rhel-84-sap-kernel-module-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@Maddosaurus Maddosaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀
Although I'd be interested to know why so many tests failed for a workflow-related change.

@Molter73
Copy link
Collaborator

Molter73 commented Sep 27, 2022

@Maddosaurus, we kinda broke OSCI yesterday, sorry about that. We are working to get it back up and running and it is unrelated to these changes.

Copy link
Collaborator

@Molter73 Molter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we unify this workflow with https://github.com/stackrox/collector/blob/master/.github/workflows/add-issue-to-triage.yml? Their goal seems to be pretty much the same, add issues/prs onto the OSS board.

@tommartensen
Copy link
Contributor Author

@Molter73 - good idea, but while the goal is the same, we only want to add only external Pull Requests. The first job of this new workflow is the filter for that. We would need to implement another condition into that to distinguish between issues and PRs. I think it's cleaner to have separate actions for each type of input.

@tommartensen
Copy link
Contributor Author

We are working to get it back up and running and it is unrelated to these changes.

You can ping me in the PR when I can rebase or re-run tests. Right now Merging is blocked.

Copy link
Collaborator

@Molter73 Molter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Molter73
Copy link
Collaborator

@tommartensen you should be able to merge now, it was blocked because we require an approval from someone in the collector-team before merging.

@tommartensen tommartensen merged commit a1e2c16 into master Sep 27, 2022
@tommartensen tommartensen deleted the tm/ROX-12735-new-prs-to-community-board branch September 27, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants