Skip to content

ROX-12735: add workflow for adding new PRs to test project board #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

tommartensen
Copy link
Contributor

Tested in private repositories.
When this has landed in master in this repo, I will:

  • open a PR from this repo to check that it IS NOT ADDED to the board
  • open a PR from a fork to check that it IS ADDED to the board

Finally, I will submit another PR to set the project URL to the real OSS Triaging board.

@tommartensen tommartensen self-assigned this Sep 26, 2022
@tommartensen tommartensen changed the title add workflow for adding new PRs to OSS Triaging board add workflow for adding new PRs to test project board Sep 26, 2022
@tommartensen tommartensen changed the title add workflow for adding new PRs to test project board ROX-12735: add workflow for adding new PRs to test project board Sep 26, 2022
@vikin91 vikin91 requested a review from jschnath September 26, 2022 13:32
Copy link
Contributor

@Maddosaurus Maddosaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for renaming the original workflow, I forgot about that 😄
Question: Do we actually add a label to an external PR or is that only the steps description?
A label would be a great idea to be able to filter for all external PRs across all org repos!

@tommartensen
Copy link
Contributor Author

e932fd6 - I wasn't sure if it was useful to add a label, but that would be it.

@Maddosaurus
Copy link
Contributor

@tommartensen Having a unified label across all repos of the stackrox org makes for a very convenient search query.
And as we want to make it as low friction as possible for our team to review PRs, having a clickable link that just lists all external PRs across all repos sounds really low friction.
So: Thank you very much for adding the label (back) in. That's awesome!

Copy link

@vikin91 vikin91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and simple - let's see it in action! Many thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants