Skip to content

Removing v0 APIs #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Nov 20, 2025
Merged

Removing v0 APIs #149

merged 19 commits into from
Nov 20, 2025
+45 −1,794

Conversation

@dmartinol
Copy link
Collaborator

@dmartinol dmartinol commented Nov 20, 2025

Last part of #76

  • Removed upstream APIs from v0 route
  • The following endpoint remain, but I'm available to removed the unnecessary ones:
    • /health: used by the operator as the liveness probe URL of the deployed registry
    • /readiness: used by the operator as the readiness probe URL of the deployed registry
    • /version: probably not in use
    • /v0/info: initially used to distinguish b/w Toolhive and upstream registry API, it's probably useless now
    • /v0/openapi.yaml

@blkt If we aim to keep any of these, we probably need to update the API Design document

dmartinol and others added 15 commits November 20, 2025 10:38
@dmartinol
using UpstreamRegistry in test functions
930824e 
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
@dmartinol
aligned toolhive test builder
5db66f6 
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
@dmartinol
aligned toolhive test builder
34a18d7 
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
@dmartinol
Merge branch 'stacklok:main' into converters_2
16db0ae
@dmjb
Merge branch 'main' into converters_2
46b9892
@dmartinol
forcing API sources to have upstream format
a3bb182 
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
@dmartinol
Merge branch 'stacklok:main' into converters_2
2492f38
@dmartinol
updated docs
3e30a57 
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
@dmartinol
forcing API sources to have upstream format
0940401 
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
@dmartinol
restored taskfile
aeca4c3 
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
@dmartinol
updated docs
9dd2e0d 
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
@dmartinol
reduced cyclomatic complexity
6a9d9a9 
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
@dmartinol
fixed test error, removed unneeded file
2aead24 
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
@dmartinol
restored v0 route to not break tests
536280a 
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
@dmartinol @claude
Simplified v0 API routes and fixed race condition in tests
5ebb0ca 
Removed deprecated server listing endpoints from v0 API routes, keeping
only the registry info and OpenAPI spec endpoints. Fixed race condition
in OpenAPI YAML endpoint by caching the spec using sync.Once to prevent
concurrent access issues during parallel test execution.

Updated Swagger documentation to reflect the removal of unused schema
types (ServerDetailResponse, ServerSummaryResponse, EnvVarDetail,
ListServersResponse) that were previously duplicated.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@dmartinol dmartinol requested a review from blkt November 20, 2025 15:42
dmartinol and others added 3 commits November 20, 2025 16:43
@dmartinol
Merge branch 'stacklok:main' into converters_3
a5aa2a4
@dmartinol
restored taskfile
78a2807 
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
@dmartinol
restored taskfile
7727a42 
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.94%. Comparing base (d15206f) to head (567cf54).

Files with missing lines Patch % Lines
internal/api/v0/routes.go 38.46% 5 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
- Coverage   65.14%   63.94%   -1.21%     
==========================================
  Files          50       50              
  Lines        2677     2585      -92     
==========================================
- Hits         1744     1653      -91     
- Misses        807      809       +2     
+ Partials      126      123       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

dmjb
dmjb previously approved these changes Nov 20, 2025
View reviewed changes
Copy link
Member

@dmjb dmjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to see so much deleted code :)

blkt
blkt previously approved these changes Nov 20, 2025
View reviewed changes
@dmartinol
using init() function to fetch openapi data
567cf54 
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
@dmartinol dmartinol dismissed stale reviews from blkt and dmjb via 567cf54 November 20, 2025 16:52
@dmartinol dmartinol enabled auto-merge (squash) November 20, 2025 17:08
@dmartinol dmartinol requested a review from blkt November 20, 2025 17:09
@dmartinol dmartinol merged commit 524fa92 into stacklok:main Nov 20, 2025
10 checks passed
@dmartinol
Copy link
Collaborator Author

dmartinol commented Nov 20, 2025

Happy to see so much deleted code :)

Yeah! The trend is pretty clear 😆
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blkt blkt blkt approved these changes

@dmjb dmjb dmjb left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dmartinol @codecov-commenter @blkt @dmjb