-
Notifications
You must be signed in to change notification settings - Fork 4
Introduced UpstreamRegistry and converter functions. #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
==========================================
- Coverage 64.07% 63.85% -0.23%
==========================================
Files 49 50 +1
Lines 2895 2941 +46
==========================================
+ Hits 1855 1878 +23
- Misses 913 930 +17
- Partials 127 133 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
blkt
previously approved these changes
Nov 13, 2025
f5d2a28 to
b1f1195
Compare
0a10d72 to
839f120
Compare
Collaborator
Author
|
@blkt @rdimitrov I re-opened this after integrating the UpstreamRegistry type |
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
c651d43 to
274b8d5
Compare
rdimitrov
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial changes for #76
Summary
This PR uses the new unified registry model (
UpstreamRegistry) that wraps the upstream Anthropic MCP format (ServerJSON) while maintaining backward compatibility with the existing ToolHive format. This is the first step in a multi-PR migration to adopt the upstream registry format internally.What Changed
New Components
UpstreamRegistry→ ToolHive (for backward compatibility)Updated Layers
pkg/sources/storage_manager.go)*toolhivetypes.UpstreamRegistryinstead of*toolhivetypes.Registrypkg/sources/)UpstreamRegistryUpstreamRegistryFetchResulttype now containsUpstreamRegistryinternal/service/file_provider.go)*toolhivetypes.RegistryUpstreamRegistry→ ToolHive before returningpkg/sync/manager.go)UpstreamRegistry→ ToolHive (for filtering)UpstreamRegistry(for storage)Backward Compatibility
✅ No breaking changes:
Testing
✅ All existing tests updated and passing
✅ New comprehensive unit tests for UpstreamRegistry
✅ Test coverage: 65.8%
✅ Zero linting issues
Migration Strategy
This is PR 1 of 3 in the format migration:
UpstreamRegistry, update storage/sources, maintain provider compatibilityUpstreamRegistry, update service/API layers