refactor: split <WorkspacePanel> into 3 internal components
#253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Nemikolh
reviewed
Aug 18, 2024
AriPerkkio
force-pushed
the
refactor/workspace-panel-split
branch
from
34c8b98 to
4ff2971
Compare
|
Weird that GitHub closes PRs when a PR reference a comment from another PR 😅 |
|
Alright I think this is ready now! 🎉 |
Nemikolh
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<WorkspacePanel>internally<WorkspacePanel>is currently difficult as it contains so much logic. Everything is declared inside a single React component. Let's split this component into three smaller ones to improve readability and maintainability.Tested manually but let's instead wait for #241 just to be sure.
@Nemikolh any thoughts about this?