-
Notifications
You must be signed in to change notification settings - Fork 82
test: add tests for ui #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
557cce6
to
af7f992
Compare
71413a0
to
5671399
Compare
test/ui/test/file-tree.test.ts
Outdated
// TODO: Figure out why this is flaky | ||
await page.waitForTimeout(1_000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't figure out what's the root cause here. Sometimes the content of previous file was shown. Here's picture that shows contents of example.html
even though example.js
is selected:
Looks like the content of example.js
was there for a while but then something else changed example.html
back on. Syntax highlight is changed to JS. 🤔
5671399
to
360aab1
Compare
@AriPerkkio I think I can't push to main directly and I do not have access to other merge options. Note that this would be contrary to our conventions and they've been used to get more details about a commit by looking at the PR number associated with a commit. In the early days of TutorialKit it was possible but we then decided to always go through PRs. Do you think you could submit a separate PR that contains all the fixes? Or multiple PRs if you prefer. |
Oh I see, other merge options are completely disabled. It would be good to have squashing enabled by default, but allow rebase when needed. I'll split this PR and move to fixes into separate PRs. 👍 |
360aab1
to
a92c964
Compare
a92c964
to
9e72229
Compare
Alright, good to go now. Other PRs are in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! 👏
Only have a minor comment on ci.yaml
and let's get this in! 🎉
Requires fix(astro): resolve Astro's private APIs properly #238<WorkspacePanelWrapper />
#240Structure
Test cases are located in
test
directory.Each test file has its own
chapter
, that containslesson
s for test cases:For example Navigation tests:
Or File Tree tests: