Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating csi-provisioner and csi-node-driver #455

Merged
merged 10 commits into from
Aug 5, 2024
Merged

Updating csi-provisioner and csi-node-driver #455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3732b06
Updating path to csi-provisioner and csi-node-driver in Helmchart
Maleware Jul 4, 2024
6f1065c
Update Changelog
Maleware Jul 4, 2024
073ee89
Merge branch 'refs/heads/main' into fix/update-path-to-csi
lfrancke Jul 19, 2024
19d0405
Revert path change
Maleware Jul 22, 2024
d70d3b7
Merge branch 'fix/update-path-to-csi' of https://github.com/stackable…
Maleware Jul 22, 2024
c1502c6
Update changelog
Maleware Jul 22, 2024
683b6e3
Merge branch 'main' into fix/update-path-to-csi
Maleware Jul 23, 2024
2bd21aa
Updating rbac rules according to csi-provisioner v5.x.x
Maleware Jul 23, 2024
b4bda57
Merge branch 'fix/update-path-to-csi' of https://github.com/stackable…
Maleware Jul 23, 2024
979bac3
Merge branch 'main' into fix/update-path-to-csi
Maleware Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ All notable changes to this project will be documented in this file.
### Added

- The associated configuration is now logged for each issued secret ([#413]).
- Chore: Upgrade csi-provisioner to 5.0.1 and csi-node-driver-registrar to 2.11.1 ([#455])

### Changed

Expand All @@ -38,6 +39,7 @@ All notable changes to this project will be documented in this file.
[#403]: https://github.com/stackabletech/secret-operator/pull/403
[#413]: https://github.com/stackabletech/secret-operator/pull/413
[#440]: https://github.com/stackabletech/secret-operator/pull/440
[#455]: https://github.com/stackabletech/secret-operator/pull/455
[#467]: https://github.com/stackabletech/secret-operator/pull/467
[#468]: https://github.com/stackabletech/secret-operator/pull/468
[#470]: https://github.com/stackabletech/secret-operator/pull/470
Expand Down
1 change: 1 addition & 0 deletions deploy/helm/secret-operator/templates/roles.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ rules:
- get
- list
- watch
- patch
- create
- delete
- apiGroups:
Expand Down
4 changes: 2 additions & 2 deletions deploy/helm/secret-operator/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ secretMigrationJob:
csiProvisioner:
image:
repository: docker.stackable.tech/k8s/sig-storage/csi-provisioner
tag: v4.0.1
tag: v5.0.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new major version. Did you research if it's backwards compatible with the previous one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/kubernetes-csi/external-provisioner/blob/v5.0.1/CHANGELOG/CHANGELOG-5.0.md

The external-provisioner now needs permissions to patch persistentvolumes. Please update your RBACs appropriately.

I have no idea if we use/need that. But it does not seem like a straightforward upgrade at least.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the PR it came from (kubernetes-csi/external-provisioner#1155): yes we do need the permission, no it doesn't look like we have take the permission already.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm updating it atm. I made another PR which was not the smartest thing. Put those together in this one now

pullPolicy: IfNotPresent
resources:
requests:
Expand All @@ -32,7 +32,7 @@ csiProvisioner:
csiNodeDriverRegistrar:
image:
repository: docker.stackable.tech/k8s/sig-storage/csi-node-driver-registrar
tag: v2.10.1
tag: v2.11.1
pullPolicy: IfNotPresent
resources:
requests:
Expand Down
Loading