Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating csi-provisioner and csi-node-driver #455

Merged
merged 10 commits into from
Aug 5, 2024
Merged

Conversation

Maleware
Copy link
Contributor

@Maleware Maleware commented Jul 4, 2024

Description

As of the update for the mirror action stackabletech/docker-images#738 path are going to change in order to automate upload of dependencies to Nexus and Harbor

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

repository: docker.stackable.tech/k8s/sig-storage/csi-provisioner
tag: v4.0.1
repository: docker.stackable.tech/k8s/csi-provisioner
tag: v5.0.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new major version. Did you research if it's backwards compatible with the previous one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/kubernetes-csi/external-provisioner/blob/v5.0.1/CHANGELOG/CHANGELOG-5.0.md

The external-provisioner now needs permissions to patch persistentvolumes. Please update your RBACs appropriately.

I have no idea if we use/need that. But it does not seem like a straightforward upgrade at least.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the PR it came from (kubernetes-csi/external-provisioner#1155): yes we do need the permission, no it doesn't look like we have take the permission already.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm updating it atm. I made another PR which was not the smartest thing. Put those together in this one now

@Maleware
Copy link
Contributor Author

I've installed the end-to-end-security demo and updated both csi components to their new corresponding versions. I didn't see any pvc's to be deleted or rolled out again nor were any problems in the communication of the tools.

However, I would like @nightkr to have a last look before this get's putted into the release.

@Maleware Maleware changed the title Updating path to csi-provisioner and csi-node-driver in Helmchart Updating csi-provisioner and csi-node-driver Jul 23, 2024
@Maleware
Copy link
Contributor Author

@Maleware
Copy link
Contributor Author

Tests failed on hyperscaler, where all right locally:

--- PASS: kuttl (121.21s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/kerberos_krb5-1.21.1_openshift-false (62.93s)
        --- PASS: kuttl/harness/tls_openshift-false (23.70s)
        --- PASS: kuttl/harness/listener_openshift-false (34.55s)
PASS

@Maleware Maleware self-assigned this Jul 23, 2024
@Maleware
Copy link
Contributor Author

Maleware commented Jul 31, 2024

We're waiting on the tests for OpenShift before we merge it. Going to be done by @adwk67

@adwk67
Copy link
Member

adwk67 commented Aug 2, 2024

🟢 secret-operator tests on OKD with helm:

--- PASS: kuttl (121.91s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/tls_openshift-true (70.74s)
        --- PASS: kuttl/harness/listener_openshift-true (84.08s)
        --- PASS: kuttl/harness/kerberos_krb5-1.21.1_openshift-true (42.06s)
PASS

🟢 secret-operator tests on OKD with OLM bundles and updated CSDI versions:

--- PASS: kuttl (95.14s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/kerberos_krb5-1.21.1_openshift-true (29.02s)
        --- PASS: kuttl/harness/tls_openshift-true (52.01s)
        --- PASS: kuttl/harness/listener_openshift-true (55.50s)
PASS

🟢 hdfs-operator test on OKD with OLM bundles and updated CSDI versions:

--- PASS: kuttl (1013.60s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/kerberos_hadoop-latest-3.3.6_zookeeper-latest-3.9.2_krb5-1.21.1_kerberos-realm-PROD.MYCORP_kerberos-backend-mit_openshift-true (1003.10s)
PASS

@Maleware Maleware added this pull request to the merge queue Aug 5, 2024
Merged via the queue into main with commit 71ec505 Aug 5, 2024
31 checks passed
@Maleware Maleware deleted the fix/update-path-to-csi branch August 5, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants