-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating csi-provisioner and csi-node-driver #455
Conversation
repository: docker.stackable.tech/k8s/sig-storage/csi-provisioner | ||
tag: v4.0.1 | ||
repository: docker.stackable.tech/k8s/csi-provisioner | ||
tag: v5.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new major version. Did you research if it's backwards compatible with the previous one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/kubernetes-csi/external-provisioner/blob/v5.0.1/CHANGELOG/CHANGELOG-5.0.md
The external-provisioner now needs permissions to patch persistentvolumes. Please update your RBACs appropriately.
I have no idea if we use/need that. But it does not seem like a straightforward upgrade at least.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the PR it came from (kubernetes-csi/external-provisioner#1155): yes we do need the permission, no it doesn't look like we have take the permission already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'm updating it atm. I made another PR which was not the smartest thing. Put those together in this one now
# Conflicts: # CHANGELOG.md
I've installed the end-to-end-security demo and updated both csi components to their new corresponding versions. I didn't see any pvc's to be deleted or rolled out again nor were any problems in the communication of the tools. However, I would like @nightkr to have a last look before this get's putted into the release. |
Tests failed on hyperscaler, where all right locally:
|
We're waiting on the tests for OpenShift before we merge it. Going to be done by @adwk67 |
🟢
🟢
🟢
|
Description
As of the update for the mirror action stackabletech/docker-images#738 path are going to change in order to automate upload of dependencies to Nexus and Harbor
Definition of Done Checklist
Author
Reviewer
Acceptance