Skip to content

Add PodListeners #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Sep 15, 2023
Merged

Add PodListeners #644

merged 15 commits into from
Sep 15, 2023

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Sep 5, 2023

Description

This is a new metadata object written in stackabletech/listener-operator#100, which gives external entities the same address information as the pod volume provides internally.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] CRD changes approved
- [x] Integration tests passed (for non trivial changes)
# Reviewer
- [x] Code contains useful comments
- [x] (Integration-)Test cases added
- [x] Documentation added or updated
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

Copy link
Contributor

@fhennig fhennig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heyho, sorry to be a PITA about the docs, but I had some ideas for how things could be documented better.

@nightkr nightkr requested a review from fhennig September 5, 2023 13:07
Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
@nightkr nightkr requested a review from fhennig September 5, 2023 13:52
fhennig
fhennig previously approved these changes Sep 5, 2023
Copy link
Contributor

@fhennig fhennig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@fhennig
Copy link
Contributor

fhennig commented Sep 5, 2023

Uhm technically I guess

CRD changes approved

the changes would need to be approved?

But maybe we can already merge this as I think it'll be an uncontroversial change. But can you put it on the agenda for the arch meeting?

@nightkr
Copy link
Member Author

nightkr commented Sep 5, 2023

Good point, I'll add it to the meeting.

siegfriedweber
siegfriedweber previously approved these changes Sep 7, 2023
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (except if you want to set the plural of PodListeners to podlisteners instead of podlistenerses as discussed in stackabletech/listener-operator#100 (comment))

siegfriedweber
siegfriedweber previously approved these changes Sep 7, 2023
maltesander
maltesander previously approved these changes Sep 14, 2023
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I like the current naming approach. Lets wait for @siegfriedweber and @Techassi still?

@maltesander maltesander added this pull request to the merge queue Sep 15, 2023
Merged via the queue into main with commit 63da978 Sep 15, 2023
@maltesander maltesander deleted the feature/podlisteners branch September 15, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants