-
-
Notifications
You must be signed in to change notification settings - Fork 15
Add PodListeners #644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PodListeners #644
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heyho, sorry to be a PITA about the docs, but I had some ideas for how things could be documented better.
Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
…tor-rs into feature/podlisteners
Uhm technically I guess
the changes would need to be approved? But maybe we can already merge this as I think it'll be an uncontroversial change. But can you put it on the agenda for the arch meeting? |
Good point, I'll add it to the meeting. |
…tor-rs into feature/podlisteners
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (except if you want to set the plural of PodListeners
to podlisteners
instead of podlistenerses
as discussed in stackabletech/listener-operator#100 (comment))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I like the current naming approach. Lets wait for @siegfriedweber and @Techassi still?
Description
This is a new metadata object written in stackabletech/listener-operator#100, which gives external entities the same address information as the pod volume provides internally.
Definition of Done Checklist