-
Notifications
You must be signed in to change notification settings - Fork 1
Write PodListeners #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write PodListeners #100
Conversation
This is largely R4R. There are currently no Antora docs, not sure about whether we want to surface this yet or treat it as an internal platform detail (@fhennig?). |
I think it's meant to be consumed and/or inform users, right? So it's a user facing feature. I'm also slightly worried that if we don't do it now, we will forget about documenting it in the future and/or have a harder time writing something about it. |
Primarily, it's intended to unblock stackabletech/secret-operator#310. It might be useful for debugging, but otherwise I'd consider it very niche. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just two typos, LGTM otherwise
tests/templates/kuttl/smoke-nodeport/02-validate-all-ingresses-are-reachable.yaml
Outdated
Show resolved
Hide resolved
tests/templates/kuttl/smoke-nodeport/02-validate-all-ingresses-are-reachable.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Part of #95, required by stackabletech/secret-operator#310. Requires stackabletech/operator-rs#644.
Definition of Done Checklist