Skip to content

Write PodListeners #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Nov 6, 2023
Merged

Write PodListeners #100

merged 31 commits into from
Nov 6, 2023

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Aug 29, 2023

Description

Part of #95, required by stackabletech/secret-operator#310. Requires stackabletech/operator-rs#644.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
# Reviewer
- [x] Code contains useful comments
- [x] (Integration-)Test cases added
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@nightkr nightkr marked this pull request as draft August 29, 2023 16:35
@nightkr nightkr changed the title Secret provisioning prep work Write PodListeners Sep 5, 2023
@nightkr nightkr marked this pull request as ready for review September 5, 2023 14:57
@nightkr
Copy link
Member Author

nightkr commented Sep 5, 2023

This is largely R4R. There are currently no Antora docs, not sure about whether we want to surface this yet or treat it as an internal platform detail (@fhennig?).

@nightkr nightkr requested a review from a team September 5, 2023 15:35
@siegfriedweber siegfriedweber removed the request for review from a team September 6, 2023 06:47
@fhennig
Copy link
Contributor

fhennig commented Sep 6, 2023

There are currently no Antora docs, not sure about whether we want to surface this yet or treat it as an internal platform detail

I think it's meant to be consumed and/or inform users, right? So it's a user facing feature. I'm also slightly worried that if we don't do it now, we will forget about documenting it in the future and/or have a harder time writing something about it.

@nightkr
Copy link
Member Author

nightkr commented Sep 6, 2023

Primarily, it's intended to unblock stackabletech/secret-operator#310. It might be useful for debugging, but otherwise I'd consider it very niche.

Copy link
Contributor

@fhennig fhennig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just two typos, LGTM otherwise

@nightkr nightkr requested a review from fhennig September 8, 2023 09:28
@nightkr nightkr requested review from siegfriedweber and a team October 30, 2023 13:38
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nightkr nightkr added this pull request to the merge queue Nov 6, 2023
Merged via the queue into main with commit 8200289 Nov 6, 2023
@lfrancke lfrancke deleted the feature/secrets branch June 19, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants