Skip to content

[Merged by Bors] - Added TlsAuthenticationProvider to be used in AuthenticationClass #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

maltesander
Copy link
Member

Description

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander marked this pull request as ready for review May 2, 2022 13:57
@maltesander maltesander requested a review from sbernauer May 2, 2022 13:57
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
But I'm not sure if we should merge this prior to presenting the ADR on Wednesday...

@maltesander
Copy link
Member Author

LGTM. But I'm not sure if we should merge this prior to presenting the ADR on Wednesday...

Yeah we can wait for it, just would like to have it in the next release!

Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@maltesander
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request May 4, 2022
## Description

- added TlsAuthenticationProvider as discussed in stackabletech/documentation#186
- removed MutualTlsVerification



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@bors
Copy link
Contributor

bors bot commented May 4, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Added TlsAuthenticationProvider to be used in AuthenticationClass [Merged by Bors] - Added TlsAuthenticationProvider to be used in AuthenticationClass May 4, 2022
@bors bors bot closed this May 4, 2022
@bors bors bot deleted the add_tls_authentication_provider branch May 4, 2022 10:13
soenkeliebau pushed a commit that referenced this pull request May 4, 2022
- added TlsAuthenticationProvider as discussed in stackabletech/documentation#186
- removed MutualTlsVerification

Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
bors bot pushed a commit that referenced this pull request May 5, 2022
## Description

Not needed any more. Left over from #387
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants