Add ADR on TLS authentication #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
bors bot
pushed a commit
to stackabletech/operator-rs
that referenced
this pull request
May 4, 2022
## Description - added TlsAuthenticationProvider as discussed in stackabletech/documentation#186 - removed MutualTlsVerification Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
maltesander
requested changes
May 4, 2022
There was a problem hiding this comment.
Maybe for completion we can add the referred tls SecretClass:
apiVersion: secrets.stackable.tech/v1alpha1
kind: SecretClass
metadata:
name: tls
spec:
backend:
autoTls:
ca:
secret:
name: secret-provisioner-tls-ca
namespace: default
autoGenerate: true
And there are some reference errors (zookeeper-tls <--> zookeeper-tls-mutual) in the image that may confuse people.
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
|
Thanks for the Review, should be addressed |
soenkeliebau
pushed a commit
to stackabletech/operator-rs
that referenced
this pull request
May 4, 2022
- added TlsAuthenticationProvider as discussed in stackabletech/documentation#186 - removed MutualTlsVerification Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
|
bors r+ |
|
Configuration problem: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For stackabletech/zookeeper-operator#466