Skip to content

[Merged by Bors] - Implement S3 bucket structs. #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from

Conversation

razvan
Copy link
Member

@razvan razvan commented Apr 25, 2022

Description

Fixes #377

Implement ADR structs from https://github.com/stackabletech/documentation/diffs/7?base_sha=9b576a1644961596cab2c812334adf164a5a1cd1&branch=adr%2Fs3&commentable=true&name=adr%2Fs3&pull_number=177&sha1=9b576a1644961596cab2c812334adf164a5a1cd1&sha2=b7cf18584869d1f64aac4c7d0be376ce07ed72c7&short_path=7e3be7c&unchanged=expanded&w=false#option5

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@razvan razvan requested a review from a team April 25, 2022 16:36
@razvan razvan linked an issue Apr 25, 2022 that may be closed by this pull request
2 tasks
@sbernauer sbernauer changed the title Implemen S3 bucket structs. Implement S3 bucket structs. Apr 26, 2022
@razvan razvan marked this pull request as ready for review April 28, 2022 12:19
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a reference for namespace. Otherwise LGTM.

razvan and others added 3 commits April 28, 2022 15:49
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@razvan razvan requested a review from maltesander April 28, 2022 14:11
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@razvan
Copy link
Member Author

razvan commented Apr 28, 2022

bors merge

@bors
Copy link
Contributor

bors bot commented Apr 28, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Implement S3 bucket structs. [Merged by Bors] - Implement S3 bucket structs. Apr 28, 2022
@bors bors bot closed this Apr 28, 2022
@bors bors bot deleted the 377-add-common-structs-code-for-s3-support branch April 28, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add common structs & code for S3 support according to ADR
2 participants