-
-
Notifications
You must be signed in to change notification settings - Fork 15
Use the local kubelet's cluster domain, rather than a random one #1071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adapted list-op as an example: stackabletech/listener-operator#317 |
Will review later when I get time, just FYI that #1066 also touches CLI arguments. |
Doesn't look like that touches the node name, but it probably makes sense to run the templating rollouts together. |
Was thinking the same. Regarding templating I already have stackabletech/operator-templating#534 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, however the tests currently fail
Also giving @razvan the chance to review |
Oh. Right. I had updated the code tets, but not the doctests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice!
Description
Part of stackabletech/issues#662, followup to #1068.
This is a breaking change (towards operators); they must now (in addition to the requirements from #1068) also provide the following environment variable:
Definition of Done Checklist
Author
Reviewer
Acceptance