feat: automatic cluster detection #1068
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbernauer
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
sbernauer
requested changes
Jul 2, 2025
| @@ -651,7 +657,25 @@ pub async fn initialize_operator( | |||
| .context(InferKubeConfigSnafu)?; | |||
| let default_namespace = kubeconfig.default_namespace.clone(); | |||
| let client = kube::Client::try_from(kubeconfig).context(CreateKubeClientSnafu)?; | |||
| let cluster_info = KubernetesClusterInfo::new(cluster_info_opts); | |||
|
|
|||
| let local_cluster_info_opts = match cluster_info_opts.kubernetes_cluster_domain { | |||
There was a problem hiding this comment.
I would prefer to not further enlarge this already gigantic file.
Please have a look at KubernetesClusterInfo::new, I'd say there is the correct place to add this, even with a todo marker :)
You need to make KubernetesClusterInfo::new fallible for that
| #[snafu(display("failed to deserialize kubelet config JSON"))] | ||
| KubeletConfigJson { source: serde_json::Error }, | ||
|
|
||
| #[snafu(display("empty Kubernetes nodes list"))] |
There was a problem hiding this comment.
Can you please explain the user why we need at least one node to avoid user frustration?
|
That was a quick implementation, didn't expect that! :) |
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes stackabletech/issues#662
Definition of Done Checklist
Author
Reviewer
Acceptance