Skip to content

fix(trino): Disable checking of trino-web-ui #1183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Subject: Add CycloneDX plugin
1 file changed, 18 insertions(+)

diff --git a/pom.xml b/pom.xml
index a1604d5ebec..3f9f7945046 100644
index a1604d5ebe..3f9f794504 100644
--- a/pom.xml
+++ b/pom.xml
@@ -2814,6 +2814,24 @@
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
From 1ec0bcdafe9f74f37b6e791e3df6b552ba748538 Mon Sep 17 00:00:00 2001
From: dervoeti <lukas.krug@stackable.tech>
Date: Wed, 18 Jun 2025 15:22:49 +0200
Subject: Disable web-ui code checking, because flow v0.241.0 for non-x86
systems requires glibc 2.35, as of 2025-06-18 our UBI image comes with glibc
2.34. This patch can likely be removed once we ship a newer version of glibc.

---
core/trino-web-ui/pom.xml | 22 ----------------------
1 file changed, 22 deletions(-)

diff --git a/core/trino-web-ui/pom.xml b/core/trino-web-ui/pom.xml
index d097a1e22f..98c7516af1 100644
--- a/core/trino-web-ui/pom.xml
+++ b/core/trino-web-ui/pom.xml
@@ -103,28 +103,6 @@
<workingDirectory>src/main/resources/webapp/src</workingDirectory>
</configuration>
</execution>
- <execution>
- <id>check (webapp)</id>
- <goals>
- <goal>npm</goal>
- </goals>
- <phase>verify</phase>
- <configuration>
- <arguments>run ${frontend.check.goal}</arguments>
- <workingDirectory>src/main/resources/webapp/src</workingDirectory>
- </configuration>
- </execution>
- <execution>
- <id>check (webapp-preview)</id>
- <goals>
- <goal>npm</goal>
- </goals>
- <phase>verify</phase>
- <configuration>
- <arguments>run ${frontend.check.goal}</arguments>
- <workingDirectory>src/main/resources/webapp-preview</workingDirectory>
- </configuration>
- </execution>
<execution>
<id>package (webapp-preview)</id>
<goals>
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
From c69033a355820753a49772be984b9c735ce8b92d Mon Sep 17 00:00:00 2001
From: dervoeti <lukas.krug@stackable.tech>
Date: Wed, 18 Jun 2025 14:05:10 +0200
Subject: Disable web-ui code checking, because flow v0.241.0 for non-x86
systems requires glibc 2.35, as of 2025-06-18 our UBI image comes with glibc
2.34. This patch can likely be removed once we ship a newer version of glibc.

---
core/trino-web-ui/pom.xml | 22 ----------------------
1 file changed, 22 deletions(-)

diff --git a/core/trino-web-ui/pom.xml b/core/trino-web-ui/pom.xml
index a783c8f989..bea233cfb9 100644
--- a/core/trino-web-ui/pom.xml
+++ b/core/trino-web-ui/pom.xml
@@ -103,28 +103,6 @@
<workingDirectory>src/main/resources/webapp/src</workingDirectory>
</configuration>
</execution>
- <execution>
- <id>check (webapp)</id>
- <goals>
- <goal>npm</goal>
- </goals>
- <phase>verify</phase>
- <configuration>
- <arguments>run ${frontend.check.goal}</arguments>
- <workingDirectory>src/main/resources/webapp/src</workingDirectory>
- </configuration>
- </execution>
- <execution>
- <id>check (webapp-preview)</id>
- <goals>
- <goal>npm</goal>
- </goals>
- <phase>verify</phase>
- <configuration>
- <arguments>run ${frontend.check.goal}</arguments>
- <workingDirectory>src/main/resources/webapp-preview</workingDirectory>
- </configuration>
- </execution>
<execution>
<id>package (webapp-preview)</id>
<goals>