fix(trino): Disable checking of trino-web-ui #1183
Open
+89
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The builds for Trino 470 and 476 currently fail on ARM.
The reason is:
#1168 switched the build command from
mvnw package
tomvnw install
, so thattrino-storage-connector
can use our patched Trino libs. That causes theverify
stage of Maven to execute as well, which for the affected Trino versions invokes flow to check the Typescript code of the Web UI. This fails on ARM, because the non x86 binaries of flow 0.241.0 require glibc 2.35 (see https://github.com/facebook/flow/releases/tag/v0.238.3). UBI comes with glibc 2.34. As we can't bump glibc and I didn't want to use an older version of flow and flow wasn't even part of the build process up until recently, I just removed the frontend checks alltogether.These patches can likely be removed once we switch to UBI 10 (I left a comment in the patch files).
Tested a local build of Trino 476 on ARM, worked (it also failed locally before this patch).
Definition of Done Checklist
Note
Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.
Please make sure all these things are done and tick the boxes
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
bake
to retrieve the image tag for<image-tagged-with-the-major-version>
.