Skip to content

fix(trino): Disable checking of trino-web-ui #1183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dervoeti
Copy link
Member

Description

The builds for Trino 470 and 476 currently fail on ARM.

The reason is:
#1168 switched the build command from mvnw package to mvnw install, so that trino-storage-connector can use our patched Trino libs. That causes the verify stage of Maven to execute as well, which for the affected Trino versions invokes flow to check the Typescript code of the Web UI. This fails on ARM, because the non x86 binaries of flow 0.241.0 require glibc 2.35 (see https://github.com/facebook/flow/releases/tag/v0.238.3). UBI comes with glibc 2.34. As we can't bump glibc and I didn't want to use an older version of flow and flow wasn't even part of the build process up until recently, I just removed the frontend checks alltogether.

These patches can likely be removed once we switch to UBI 10 (I left a comment in the patch files).

Tested a local build of Trino 476 on ARM, worked (it also failed locally before this patch).

Definition of Done Checklist

Note

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.

Please make sure all these things are done and tick the boxes

  • Changes are OpenShift compatible
  • All added packages (via microdnf or otherwise) have a comment on why they are added
  • Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
  • All packages should have (if available) signatures/hashes verified
  • Add an entry to the CHANGELOG.md file
  • Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@dervoeti dervoeti moved this to Development: Waiting for Review in Stackable Engineering Jun 18, 2025
@dervoeti dervoeti self-assigned this Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Development: Waiting for Review
Development

Successfully merging this pull request may close these issues.

1 participant