Fix removeRigidContact #273
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I noticed an error while using rigid contact, the number of equalities is decremented no matter what when removeRigidContact is called.
tsid/src/formulations/inverse-dynamics-formulation-acc-force.cpp
Line 559 in 6e0293b
However, is the motion task has been added with a priority > 0, it shouldn't affect the number of equalities
tsid/src/formulations/inverse-dynamics-formulation-acc-force.cpp
Line 82 in 6e0293b
So nEq was underflowing in our walking scenario where we constantly break and make contact.
Here is a small fix