Skip to content

Fix removeRigidContact #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 29, 2025
Merged

Conversation

EtienneAr
Copy link
Contributor

Hello,

I noticed an error while using rigid contact, the number of equalities is decremented no matter what when removeRigidContact is called.

m_eq -= (*it)->motionConstraint->rows();

However, is the motion task has been added with a priority > 0, it shouldn't affect the number of equalities

if (priorityLevel == 0) m_eq += c.rows();

So nEq was underflowing in our walking scenario where we constantly break and make contact.

Here is a small fix

@EtienneAr EtienneAr changed the title Fix remove rigid contact Fix removeRigidContact Jul 28, 2025
@andreadelprete
Copy link
Collaborator

Thanks for your contribution @EtienneAr . The code looks good to me. I wait to see if somebody else has something to say, otherwise I'll move on with a merge.

@nim65s nim65s merged commit 31a0b7a into stack-of-tasks:devel Jul 29, 2025
7 of 10 checks passed
@EtienneAr EtienneAr deleted the fix_removeRigidContact branch July 29, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants