Skip to content

Update C++ standard for clang-format to 11, apply updated formatting rules #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ManifoldFR
Copy link
Member

@ManifoldFR ManifoldFR commented Apr 25, 2025

  • pre-commit config : actually delegate to .clang-format config file
  • .clang-format : increase Standard to Cpp11
  • pre-commit: run all
  • .git-blame-ignore-revs : update
  • Update CHANGELOG

This PR would require setting the minimum required version of the C++ standard to 11 I think, because stuff like vector<A<T>> without a space between the last two angle brackets for templates doesn't work on some C++03 compilers if I recall correctly.

@ManifoldFR
Copy link
Member Author

I think we should merge this before #545. Then I can pop off the last commit off of that PR since we won't have to fight the formatting.

@jorisv jorisv merged commit 97290f4 into stack-of-tasks:devel Apr 25, 2025
31 of 33 checks passed
@ManifoldFR ManifoldFR deleted the topic/update-clang-format-cpp-standard branch April 25, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants