-
Notifications
You must be signed in to change notification settings - Fork 30
Pystac v1.0 compatability #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
205df7d
to
99c2ae5
Compare
99c2ae5
to
e8b6f2c
Compare
Ok, I've fixed up stuff to use extensions correctly (hopefully). There's some issues with a couple subpackages, some of which are due to STAC v1 validation, some of which are landsat infrastructure issues. I've cataloged them as best as I can in this PR's description so we can try to axe them down. For the aster+cgls_lc100, @lossyrob can you advise on what we should do about the band names? The landsat stuff is trickier -- relying on someone's else's schemas and collections as a part of our test suite seems fragile. |
For Aster, it looks like the center wavelength falls in the "green" category from this table, so I'd go with that.... For CGLS_LC100 I'd remove the common_name |
713a605
to
c18b6ca
Compare
The big changes are to StacIO and extensions.
c18b6ca
to
d99dadb
Compare
Updated for the v0.2 reorganization (makes this PR a lot smaller). |
@duckontheweb mind giving this one a once-over? It's much simpler now w/o the dataset packages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just a couple of minor comments!
This will become available after PySTAC 1.0.0-rc.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Feedback appreciated, especially on the
StacIO
stuff, where I did my best to just port over the old behavior to The New Way™.read_text
without orjson pystac#348 lands in the next beta release[ ] Pystac 1.0 resolves parent collections, so some landset tests are broken because https://landsatlook.usgs.gov/data/collection02/landsat-c2l2-sr.json is not publicly accessible.[ ] Other landsat tests break because landsat schema is no longer accessible: https://landsat.usgs.gov/stac/landsat-extension/schema.json.cc @volaya since you said you might be working on this effort as well.