Skip to content

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented May 21, 2021

Feedback appreciated, especially on the StacIO stuff, where I did my best to just port over the old behavior to The New Way™.

cc @volaya since you said you might be working on this effort as well.

@gadomski gadomski force-pushed the feature/pystac-v1.0 branch from 99c2ae5 to e8b6f2c Compare May 27, 2021 13:42
@gadomski
Copy link
Member Author

gadomski commented May 27, 2021

Ok, I've fixed up stuff to use extensions correctly (hopefully). There's some issues with a couple subpackages, some of which are due to STAC v1 validation, some of which are landsat infrastructure issues. I've cataloged them as best as I can in this PR's description so we can try to axe them down.

For the aster+cgls_lc100, @lossyrob can you advise on what we should do about the band names?

The landsat stuff is trickier -- relying on someone's else's schemas and collections as a part of our test suite seems fragile.

@lossyrob
Copy link
Member

For Aster, it looks like the center wavelength falls in the "green" category from this table, so I'd go with that....

For CGLS_LC100 I'd remove the common_name

@gadomski gadomski modified the milestones: v0.1.6, v0.2.0 May 28, 2021
@gadomski gadomski added the enhancement New feature or request label Jun 1, 2021
@gadomski gadomski removed this from the v0.3.0 milestone Jun 11, 2021
@gadomski gadomski force-pushed the feature/pystac-v1.0 branch from 713a605 to c18b6ca Compare June 15, 2021 14:43
The big changes are to StacIO and extensions.
@gadomski gadomski force-pushed the feature/pystac-v1.0 branch from c18b6ca to d99dadb Compare June 15, 2021 14:56
@gadomski
Copy link
Member Author

Updated for the v0.2 reorganization (makes this PR a lot smaller).

gadomski added a commit to stactools-packages/goes that referenced this pull request Jun 15, 2021
gadomski added a commit to stactools-packages/goes that referenced this pull request Jun 15, 2021
@gadomski gadomski linked an issue Jun 16, 2021 that may be closed by this pull request
@gadomski gadomski added this to the v0.2.1 milestone Jun 16, 2021
@gadomski
Copy link
Member Author

@duckontheweb mind giving this one a once-over? It's much simpler now w/o the dataset packages.

@gadomski gadomski removed the request for review from lossyrob June 17, 2021 12:28
Copy link

@duckontheweb duckontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a couple of minor comments!

Copy link

@duckontheweb duckontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When should we add pystac v1.0 support?
3 participants