Skip to content

Split default IO down into to/from href methods #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2021
Merged

Split default IO down into to/from href methods #354

merged 2 commits into from
May 23, 2021

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented May 21, 2021

Related Issue(s): stac-utils/stactools#113

Description: This allows subclasses of DefaultStacIO to not have to re-impelment link resolution if they don't want to. I would like this for, e.g., this fsspec io, where right now I'm just copying the link resolution code from pystac.

PR Checklist:

  • Code is formatted (run scripts/format)
  • Tests pass (run scripts/test)
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

gadomski added 2 commits May 21, 2021 11:01
This allows subclasses of DefaultStacIO to not have to re-impelment link
resolution if they don't want to.
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2021

Codecov Report

Merging #354 (8cedba5) into main (61f62b1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #354   +/-   ##
=======================================
  Coverage   88.58%   88.59%           
=======================================
  Files          36       36           
  Lines        4625     4629    +4     
=======================================
+ Hits         4097     4101    +4     
  Misses        528      528           
Impacted Files Coverage Δ
pystac/stac_io.py 72.38% <100.00%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61f62b1...8cedba5. Read the comment docs.

@lossyrob lossyrob merged commit 016e56c into stac-utils:main May 23, 2021
@gadomski gadomski deleted the feature/split-default-io-read-write branch May 24, 2021 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants