Override more methods in PipeStream, ShellStream #1637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Where beneficial, add additional overrides from the base Stream class. Namely the Span variants and for PipeStream, the WriteAsync variants (see comments). The change also adds an internal type borrowed from the runtime repo for easier buffer management, which could also be used elsewhere.
Rob-Hague
commented
May 3, 2025
| @@ -9,6 +9,7 @@ | |||
| <SignAssembly>true</SignAssembly> | |||
| <AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)Renci.SshNet.snk</AssemblyOriginatorKeyFile> | |||
| <GenerateDocumentationFile>true</GenerateDocumentationFile> | |||
| <EnablePackageValidation>true</EnablePackageValidation> | |||
There was a problem hiding this comment.
unrelated change, this just adds validation during dotnet pack that e.g. a netstandard build is compatible with netcore
https://learn.microsoft.com/dotnet/fundamentals/apicompat/package-validation/overview
Rob-Hague
commented
May 3, 2025
Comment on lines
+12
to
+20
| try | ||
| { | ||
| stream.Dispose(); | ||
| return default; | ||
| } | ||
| catch (Exception exc) | ||
| { | ||
| return new ValueTask(Task.FromException(exc)); | ||
| } |
There was a problem hiding this comment.
unrelated, just copying the netcore impl
WojciechNagorski
approved these changes
May 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where beneficial, add additional overrides from the base Stream class. Namely the Span variants and for PipeStream, the WriteAsync variants (see comments).
The change also adds an internal type borrowed from the runtime repo for easier buffer management, which could also be used elsewhere.