Skip to content

mesh_t based ruby bindings #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Dec 10, 2013
Merged

mesh_t based ruby bindings #50

merged 27 commits into from
Dec 10, 2013

Conversation

sshirokov
Copy link
Owner

This PR will update the ruby bindings for the csg gem to be based on the new mesh_t type from #49

This will also bump the gem version to 0.1.0 because of the API shuffling I'm doing.

Tasks

  • Wrap mesh_t into CSG::Native
  • Wrap mesh_read_file to return a CSG::Native
  • Update CSG::Solid to be mesh_t backed instead of stl_object
  • Add to_bsp to the mesh_t prototype returning a new BSP tree
  • Tests for mesh_t->to_bsp
  • bsp_to_mesh helper to not deal with CPP generated calls from ruby
  • Tests for bsp_to_mesh
  • Update the FFI binding to include the new method
  • FFI wrapper to construct BSP-backed meshes in ruby
  • Do everything as a mesh in the ruby wrapper
  • Map appropriate methods for I/O and operations

Maybe this also?

  • Remove the stl_object from being exported to ruby?

@sshirokov
Bumping the gemspec version in anticpation of Breaking Everything
85fe324 
Also expanding `s.files` entry to be all ruby in lib/**/*.rb
@sshirokov
WIP: Scaffold for mesh struct
4a962ed
@sshirokov
Bump Gemspec to new csgtool, and apperantly a new ffi
f2c9ff0
@sshirokov
A mesh->destroy() helper that doesn't need access to a struct FP
f7f71f5 
This is mainly to make the ruby helper deallocator trivial.
@sshirokov
A destructor for the mesh native type
8f77423
@sshirokov
A wrapper with actual callbacks
630a8a8
@sshirokov
GO STUPID SPACING! YEAH! AWESOME!
99b8b7d
@sshirokov
EVEN MORE WARNING FOR YOU
3c50f3e
@sshirokov
Updating ruby wrapper and csgtool.rb
76b07e6 
Undecided on if I want to keep the STLObject exported for write, or not.

The C-API sort-of favors C, and making a mesh would probs entangle the existing
BSPNode with the ruby GC :(
@sshirokov
NULL checks. In ruby. This is what the future is.
eab8cff
@sshirokov
Copy link
Owner Author

As this stands, there's not an output that won't require a conversion to STL before write unless this gets re-written to use mesh_t backed BSP trees that I can call bsp->write(.., path) on, implicitly knowing that they will be written as STL.

On the bright side, I don't think the ruby API actually needs to change at all.

@sshirokov
Copy link
Owner Author

Gonna remap the ruby wrapper to universally use mesh_t and a new to_bsp method

@sshirokov
mesh_t->to_bsp()
20627ec 
this required moving the bsp_mesh_t into a new header
so that it wouldn't be circular bsp.h<->mesh.h
@sshirokov
Include the bsp_mesh.h header for tests
4a1f501
@sshirokov
Test for mesh_t->to_bsp()
f33cd2b
@sshirokov
Duplicated colde now calls the dupe
9caf43b 
mesh_to_bsp now calls mesh->to_bsp
@sshirokov
Ruby, meet mesh.to_bsp, and don't have a off-by-one-method error
f53a7fb
@sshirokov
bsp_to_mesh(bsp, copy)
b93ee52
@sshirokov
Change the concern from a tree to a mesh in side CSG::Solid
602a788
@sshirokov
Remove the old code entirely
3dbf78a
@sshirokov
WIP: New bsp_#{name} code with notes at the end
7b75937
@sshirokov
Theoretically functional bsp_* functions
7e4a6c7
@sshirokov
Test for bsp_to_mesh
20bc146
@sshirokov
mesh_t->write() takes a last parameter specyfing the type.
9f6385c 
Right now, it basically asserts that you pass "STL"
but the intent is to remove any surprise from what arrives on
the disk after a call to write rather than just having a convention of
knowledge about the underlying type's prototype
@sshirokov
CSG::Solid#write
36f54da
@sshirokov
Update the csgtool.rb driver to use the new Solid#write(path) API
2a16369
@sshirokov
Don't leak in the failure condition
42b8541
skalnik
skalnik reviewed Dec 10, 2013
View reviewed changes
lib/csg.rb Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# Assign

sshirokov added a commit that referenced this pull request Dec 10, 2013
@sshirokov
Merge pull request #50 from sshirokov/ruby-mesh-binding
ec0dc6b 
mesh_t based ruby bindings
@sshirokov sshirokov merged commit ec0dc6b into master Dec 10, 2013
@sshirokov sshirokov deleted the ruby-mesh-binding branch December 10, 2013 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sshirokov @skalnik