Skip to content

Generic Mesh Type #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Dec 3, 2013
Merged

Generic Mesh Type #49

merged 30 commits into from
Dec 3, 2013

Conversation

sshirokov
Copy link
Owner

This work adds mesh_t and assorted methods for having a single type to deal with for CSG interactions. This work is the foundation for additional I/O formats.

Plan

  • mesh_t base and methods
  • stl_mesh_t prototype
  • stl_mesh_t tests
  • Input should produce a mesh_t type instead of stl_object
  • ☝️ Tests
  • Use mesh_t methods to produce BSP trees instead of stl_to_* and *_to_stl methods.
  • mesh_t.write method
  • ☝️ Tests
  • Use mesh_t.write to write results to disk
  • Default write method should be able to break polygons > 3 verts down before writing

Maybe?

  • bsp_node_t backed mesh_t to avoid boilerplate conversions in the caller

AND THEN

  • Update the FFI bindings to hide stl_object and use mesh_t
  • Update csgtool.rb to use new bindings

AND Finally

  • Make sure there are no new leaks

@sshirokov
Awkward space.
f3ab41a
@sshirokov
Starting the mesh_t* type
4052a07
@sshirokov
Fixing up the mesh type and adding some test
29c02d7
@sshirokov
In theory, I have an stl_mesh_t
86537b3
@sshirokov
mesh_init() signature takes a second param for data.
959d8a7
@sshirokov
stl_mesh_t* tests
0d9bccd
@sshirokov
reader.[ch] scaffold.
ed7d596 
Using the same pattern from commands, a list of
readers that should be tried in order.

Eash "reader" is a pair of functions of a path.

  * a `predicate` which should cheaply determine
    if a file should be read at all.
  * a `loader` which should actually produce a
    fresh-and-valid `mesh_t *`
@sshirokov
Starting reader tests
47f57af
@sshirokov
Meet mesh_t* reader_load(char *)
38daa20
@sshirokov
Test reader_load() on an STL
2d600f6
@sshirokov
Kick the stl predicate down the road for a little bit
e2e0c57
@sshirokov
A theoretical ->write method
c6a8fba
@sshirokov
Wire up the default write function into the proto
cb36075
@sshirokov
mesh_to_bsp()
d52e662
@sshirokov
Move src/commands to mesh_t from stl_object
9dd036a
@sshirokov
DO NOT LEAK. LEAKS ARE NOT FUN.
db1ebcd
@sshirokov
WIP: Test script [failing]
094382b
@sshirokov
Append .stl to path in the default writer.
fcbd713
@sshirokov
Revert "Append .stl to path in the default writer."
1915c8c 
This reverts commit fcbd713.
@sshirokov
Tests for mesh_t->write()
2505f86
@sshirokov
Wrap reader_load() with mesh_read() for better reading
3ce02b6
@sshirokov
mesh_read -> mesh_read_file
ace0a2c
@sshirokov
Update callsites to mesh_read_file()
800af8a
@sshirokov
Don't expose the stl prototype methods
40c1357
@sshirokov
bsp_mesh_t and tests
3a8658a
@sshirokov
Use bsp-backed mesh_t in command
8be9ee6
@sshirokov
null poly nodes count, too
fd86f90
@sshirokov
polys_to_tris(dst, src)
d0184ed 
Copy a polygon list to a triangle list.
@sshirokov
Export tests
731e70d
@sshirokov
Use the default writer from BSP, now that it can make triangles
1686f57
@sshirokov
Copy link
Owner Author

> 77000 loops through main said we're fine on leaks.

@sshirokov
Copy link
Owner Author

Gonna do the ruby binding in a new PR.

sshirokov added a commit that referenced this pull request Dec 3, 2013
@sshirokov
Merge pull request #49 from sshirokov/mesh-type
23a65a8 
Generic Mesh Type
@sshirokov sshirokov merged commit 23a65a8 into master Dec 3, 2013
@sshirokov sshirokov mentioned this pull request Dec 3, 2013
Merged
12 tasks
@sshirokov sshirokov deleted the mesh-type branch October 31, 2014 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sshirokov