Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic/OpeningFunctionBraceBsdAllman: bug fix - prevent removing return types #3358

Merged
merged 1 commit into from
May 27, 2021
Merged

Generic/OpeningFunctionBraceBsdAllman: bug fix - prevent removing return types #3358

merged 1 commit into from
May 27, 2021

Commits on May 15, 2021

  1. Generic/OpeningFunctionBraceBsdAllman: bug fix - prevent removing ret… 

    …urn types

As reported in 3357, the `Generic.Functions.OpeningFunctionBraceBsdAllman` sniff would remove return types (and comments) when fixing code where blank lines existed between the end of the function declaration and the open brace.

This commit fixes that bug.

In the case of comments, the `BraceSpacing` error will no longer auto-fix as a dev should decide where the comment should go and/or whether it should be removed.

Includes unit tests.

Fixes 3357
    @jrfnl
    jrfnl committed May 15, 2021
    Configuration menu
    Copy the full SHA
    8defc6e View commit details
    Browse the repository at this point in the history