Generic/OpeningFunctionBraceBsdAllman: bug fix - prevent removing return types #3358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urn types As reported in 3357, the `Generic.Functions.OpeningFunctionBraceBsdAllman` sniff would remove return types (and comments) when fixing code where blank lines existed between the end of the function declaration and the open brace. This commit fixes that bug. In the case of comments, the `BraceSpacing` error will no longer auto-fix as a dev should decide where the comment should go and/or whether it should be removed. Includes unit tests. Fixes 3357
|
Thanks for this fix |
jrfnl
deleted the
feature/3357-generic-openingfunctionbracebsdallman-fixer-removes-return-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #3357, the
Generic.Functions.OpeningFunctionBraceBsdAllmansniff would remove return types (and comments) when fixing code where blank lines existed between the end of the function declaration and the open brace.This commit fixes that bug.
In the case of comments, the
BraceSpacingerror will no longer auto-fix as a dev should decide where the comment should go and/or whether it should be removed.Includes unit tests.
Fixes #3357
Previously #1931, #1938