Tokenize yield keyword as T_YIELD on PHP 5.4, and yield from as T_YIELD_FROM on PHP < 7.0
#1524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ktomk I've updated my PR to tokenize correctly |
michalbundyra
changed the title
yield keyword as T_YIELD on PHP 5.4yield keyword as T_YIELD on PHP 5.4, and yield from as T_YIELD_FROM on PHP < 7.0
Member
|
Thanks a lot for doing this. Looks like it is working well. |
jrfnl
added a commit
to PHPCSStandards/PHPCSUtils
that referenced
this pull request
May 17, 2024
…h PHPCS < 3.1.0 Prior to PHPCS 3.1.0, the `yield` keyword tokenization was not backfilled for PHP 5.4 and the `yield from` tokenization was not backfilled for PHP < 7.0. This commit adds a work-around to the utility method to handle this situation correctly. Includes unit tests covering the issue. Refs: * squizlabs/PHP_CodeSniffer#1513 * squizlabs/PHP_CodeSniffer#1524
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1513
With these changes PR #1492 is not gonna fail.