Skip to content

[3.0] Added missing lowercase keywords #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 1, 2017
Merged

[3.0] Added missing lowercase keywords #1492

merged 2 commits into from
Sep 1, 2017

Conversation

@michalbundyra
Copy link
Contributor

@michalbundyra michalbundyra commented May 30, 2017 •
edited
Loading

  • function (closure)
  • parent
  • self
  • yield
  • yield from

@michalbundyra michalbundyra changed the base branch from 3.0 to master June 6, 2017 22:36
@gsherwood gsherwood added this to the 3.1.0 milestone Jun 11, 2017
@jrfnl
Copy link
Contributor

jrfnl commented Jun 17, 2017

Partial duplicate of #1458 ?

@jrfnl jrfnl mentioned this pull request Jun 17, 2017
Closed
@michalbundyra michalbundyra mentioned this pull request Jun 21, 2017
Merged
@jrfnl
Copy link
Contributor

jrfnl commented Jul 15, 2017

After the update of #1524, should T_YIELD_FROM be added here as well ?

@michalbundyra
Copy link
Contributor Author

michalbundyra commented Jul 15, 2017

@jrfnl Updated :-) Of course #1524 must be merged first.

@gmponos gmponos mentioned this pull request Jul 23, 2017
Closed
@michalbundyra michalbundyra force-pushed the hotfix/lowercase-keywords-3.0 branch from 6c59612 to 527f2bb Compare July 24, 2017 10:16
@michalbundyra
Copy link
Contributor Author

michalbundyra commented Jul 24, 2017

Rebased, now all tests pass.

@michalbundyra michalbundyra mentioned this pull request Jul 24, 2017
Merged
@gsherwood gsherwood merged commit 527f2bb into squizlabs:master Sep 1, 2017
gsherwood added a commit that referenced this pull request Sep 1, 2017
@gsherwood
Changelog for #1492
1fdc34e
@gsherwood
Copy link
Member

gsherwood commented Sep 1, 2017

Thanks for the PR and the tests.

@michalbundyra michalbundyra deleted the hotfix/lowercase-keywords-3.0 branch September 1, 2017 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@michalbundyra @jrfnl @gsherwood