PR: Only show UpdateManager statusbar widget while updating and when updates are available #21836

mrclary · 2024-02-27T04:41:18Z

Description of Changes

The update manager statusbar widget is now hidden except when
- An update is available
- Downloading an update
Bootstrap and dev versions no longer block checking for updates at startup. Bootstrap and editable installs of Spyder check for updates using the release url.
"Check for updates" action removed from the statusbar widget
"Spyder: " text is removed from the statusbar status value. This was used previously as a prefix to the Spyder version that would be displayed when idle. Now that the widget is hidden when idle, "Spyder: " prefix seems unnecessary.
Uncaught exceptions in the update worker are sent to the error reporter.
version_info now includes pre-release item. To ensure that the development version is greater than the latest release tag, including unstable releases, this field should be used immediately following unstable releases, i.e. returning to work.
Local conda channels are remapped to conda-forge when the installer is built. This ensures that the updater correctly identifies Spyder's conda channel.
Fixed issue where shortcut name was incorrect when launching after update.
Fixed issue where install.bat executes incorrectly because it is over-written during update.

Fixes #21882

Requires conda-forge/spyder-feedstock#167

ccordoba12

@mrclary, a couple of small comments for now.

spyder/plugins/updatemanager/widgets/status.py

ccordoba12

Thanks @mrclary for your work on this!

spyder/plugins/updatemanager/container.py

spyder/__init__.py

spyder/plugins/updatemanager/container.py

spyder/plugins/updatemanager/plugin.py

spyder/__init__.py

spyder/plugins/updatemanager/workers.py

ccordoba12 · 2024-04-09T16:41:29Z

@mrclary, please rebase to get the fixes to our tests from last week.

@dalthviz, could you review how the update process works with these changes? Thanks!

pyproject.toml

spyder/plugins/updatemanager/workers.py

…is no longer needed either.

This reverts commit f64ff79, reversing changes made to 6ecbbae.

I don't think there is a way to remap the local channel to different channels depending on the package, e.g. spyder-kernels to use conda-forge/label/spyder_kernels_rc and spyder to use conda-forge/label/spyder_dev. However, I think conda-forge will be sufficient to allow the updater to perform its actions.

Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>

…ING_LOG_BUILD on pre-/release.

…ne if Spyder was still running. The shortcut no longer uses spyder.exe, but rather pythonw.exe. To positively identify Spyder, we need to expose the WindowTitle using verbosity and searching for "Spyder".

…Spyder

…for Windows, otherwise adverse behavior occurs when executing a file that is being over-written. Copy for macOS and Linux too, just to be safe.

mrclary · 2024-04-16T05:20:26Z

Okay, I pushed up a fix. I decided to just copy install.[sh|bat] to a temporary directory. This seems to work for Windows now, and while not strictly necessary for macOS and Linux, perhaps an added precaution.

dalthviz · 2024-04-16T23:47:05Z

I tested changing the installer Spyder version to 6.0.0a3 and seems like things are working now for that case (I got to 6.0.0a4 without issues) 🎉 However, after uninstalling, reinstalling and setting the Spyder version to 5.5.4, tried to do an update and I got the following warning message:

I think this is probably due to not having an alpha release with the new installers naming, right? Checking 6.0.0a4 the installers put the version in the installer name (so instead of Spyder-Windows-x86_64.exe currently the release has Spyder-6.0.0a4-Windows-x86_64.exe). Maybe we should add manually the installers with the expected naming to the 6.0.0a4 GitHub release to test?

Also, kind of out of topic but, while doing the update testing, from time to time I have seen over the Spyder IPython Console a message related with the kernel?

dalthviz · 2024-04-17T00:33:49Z

Just for testing, I added the expected asset to the 6.0.0a4 release and one thing I noticed is that it seems like the download percentage shown from the status bar is different from the dialog one sometimes 🤔

Also, due to the install.log the triggered unistaller showed the reboot screen:

Could be possible to set the path where the installer.log is stored by any chance? I think is something nice to have (at least for the installers from PRs and things like that) but is also a little bit annoying since seems like it is shared between installers executions and even accepting to do a reboot doesn't actually remove it (so it needs to be manually removed otherwise you are not able to use again the default spyder-6 directory for the installation for example)

Also, noticed that the tabs after finishing the update and Spyder opening (Spyder 6.0.0a4) have a weird style 🤔

Anyhow, regardless of the above, seems like the update mechanism for a major version update works too 👍

mrclary · 2024-04-17T04:05:01Z

I tested changing the installer Spyder version to 6.0.0a3 and seems like things are working now for that case (I got to 6.0.0a4 without issues) 🎉 However, after uninstalling, reinstalling and setting the Spyder version to 5.5.4, tried to do an update and I got the following warning message:

I think this is probably due to not having an alpha release with the new installers naming, right? Checking 6.0.0a4 the installers put the version in the installer name (so instead of Spyder-Windows-x86_64.exe currently the release has Spyder-6.0.0a4-Windows-x86_64.exe).

That is correct.

Also, kind of out of topic but, while doing the update testing, from time to time I have seen over the Spyder IPython Console a message related with the kernel?

I have not seen that before. But let's keep an eye on it for alpha-5.

mrclary · 2024-04-17T04:10:40Z

Just for testing, I added the expected asset to the 6.0.0a4 release and one thing I noticed is that it seems like the download percentage shown from the status bar is different from the dialog one sometimes 🤔

That is strange, since it should be the same exact value fed to both. I wonder if there is a latency in the display of the window causing it to appear to be behind the statusbar.

Also, due to the install.log the triggered unistaller showed the reboot screen:

Could be possible to set the path where the installer.log is stored by any chance?

Unfortunately not. This is fixed by NSIS and not configurable.

I think is something nice to have (at least for the installers from PRs and things like that) but is also a little bit annoying since seems like it is shared between installers executions and even accepting to do a reboot doesn't actually remove it (so it needs to be manually removed otherwise you are not able to use again the default spyder-6 directory for the installation for example)

Yes, it is annoying. This should not be the case, however for the pre-release and releases. The install logging is disabled for these builds.

Also, noticed that the tabs after finishing the update and Spyder opening (Spyder 6.0.0a4) have a weird style 🤔

I have not seen this, but we should monitor it after alpha-5

Anyhow, regardless of the above, seems like the update mechanism for a major version update works too 👍

Great!

dalthviz

Thanks @mrclary ! 👍

ccordoba12 · 2024-04-17T23:41:28Z

Also, noticed that the tabs after finishing the update and Spyder opening (Spyder 6.0.0a4) have a weird style 🤔

This should have been fixed by commit eabb402. At least it's working for me on Linux. But I'll test on Windows and submit a separate PR to fix it if that's not the case.

ccordoba12

Thanks for all your hard work to improve our installers @mrclary!

mrclary self-assigned this Feb 27, 2024

mrclary marked this pull request as ready for review February 27, 2024 06:26

mrclary requested review from ccordoba12 and CAM-Gerlach February 27, 2024 06:26

ccordoba12 added this to the v6.0beta1 milestone Feb 27, 2024

ccordoba12 added type:Enhancement User Experience (UX) labels Feb 27, 2024

ccordoba12 reviewed Feb 27, 2024

View reviewed changes

spyder/plugins/updatemanager/widgets/status.py Show resolved Hide resolved

spyder/plugins/updatemanager/widgets/status.py Show resolved Hide resolved

mrclary force-pushed the updater branch from ec60b69 to 75d8c13 Compare February 29, 2024 21:56

ccordoba12 mentioned this pull request Mar 2, 2024

PR: Fix visibility of status bar widget that checks for Spyder updates (Application) #21851

Merged

mrclary force-pushed the updater branch 2 times, most recently from a899c0e to de3aa11 Compare March 7, 2024 01:41

mrclary force-pushed the updater branch 3 times, most recently from c7e97f1 to 4a1e1a3 Compare March 13, 2024 21:53

mrclary mentioned this pull request Mar 13, 2024

Connect errors without specific handling triggered while doing a check for updates to our error report dialog #21882

Closed

mrclary force-pushed the updater branch 2 times, most recently from 7eb8efc to 839a03f Compare March 14, 2024 21:19

mrclary force-pushed the updater branch 3 times, most recently from 9473d1f to 97aa75f Compare March 26, 2024 14:16

mrclary mentioned this pull request Mar 26, 2024

Ensure packaging is included for host conda-forge/spyder-feedstock#167

Merged

5 tasks

mrclary force-pushed the updater branch from fd7e457 to 0062dc7 Compare April 2, 2024 16:03

ccordoba12 reviewed Apr 9, 2024

View reviewed changes

ccordoba12 requested a review from dalthviz April 9, 2024 16:41

mrclary force-pushed the updater branch from f41c6e2 to 02c64f5 Compare April 9, 2024 17:43

ccordoba12 reviewed Apr 9, 2024

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

ccordoba12 reviewed Apr 9, 2024

View reviewed changes

spyder/plugins/updatemanager/workers.py Outdated Show resolved Hide resolved

mrclary force-pushed the updater branch from 02c64f5 to d95b4e8 Compare April 10, 2024 00:59

mrclary and others added 17 commits April 15, 2024 22:11

Do not use "Spyder: " in statusbar status value

599755e

Remove obsolete statuses

54671e9

Do not need base tooltip, since widget is hidden.

62eb49d

Remove "Check for updates..." widget action.

e57514f

Do not show statusbar widget while checking for updates. The spinner …

f6aefbd

…is no longer needed either.

Send untracked errors from update worker to the error reporter

d41092b

Add pre-release element to version_info, when appropriate.

d16b13b

Revert "Merge from 5.x: PR spyder-ide#21910"

9d14a6b

This reverts commit f64ff79, reversing changes made to 6ecbbae.

Explicitly add packaging to Python build system

049793b

Apply suggestions from code review

29182fe

Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>

Apply suggestions from code review

89d26bd

Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>

Make CONDA_BLD_PATH available to the entire job and condition NSIS_US…

5f7a58c

…ING_LOG_BUILD on pre-/release.

Fix issue where install script for windows could not properly determi…

f1850d0

…ne if Spyder was still running. The shortcut no longer uses spyder.exe, but rather pythonw.exe. To positively identify Spyder, we need to expose the WindowTitle using verbosity and searching for "Spyder".

Fix issue where install script used incorrect shortcut for launching …

d52b7a1

…Spyder

Fix continue message

48ff669

Copy install.[sh|bat] script to temporary location. This is required …

61efbc4

…for Windows, otherwise adverse behavior occurs when executing a file that is being over-written. Copy for macOS and Linux too, just to be safe.

mrclary force-pushed the updater branch from 4a40b38 to 61efbc4 Compare April 16, 2024 05:11

dalthviz approved these changes Apr 17, 2024

View reviewed changes

dalthviz requested a review from ccordoba12 April 17, 2024 19:54

ccordoba12 approved these changes Apr 17, 2024

View reviewed changes

ccordoba12 merged commit 845b331 into spyder-ide:master Apr 18, 2024
23 checks passed

mrclary deleted the updater branch April 18, 2024 15:09

mrclary mentioned this pull request May 13, 2024

Conda-based Installer Parent Issue #20001

Closed

16 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PR: Only show UpdateManager statusbar widget while updating and when updates are available #21836

PR: Only show UpdateManager statusbar widget while updating and when updates are available #21836

mrclary commented Feb 27, 2024 •

edited by ccordoba12

Loading

ccordoba12 left a comment

ccordoba12 left a comment

ccordoba12 commented Apr 9, 2024

mrclary commented Apr 16, 2024

dalthviz commented Apr 16, 2024

dalthviz commented Apr 17, 2024

mrclary commented Apr 17, 2024

mrclary commented Apr 17, 2024

dalthviz left a comment

ccordoba12 commented Apr 17, 2024 •

edited

Loading

ccordoba12 left a comment

PR: Only show UpdateManager statusbar widget while updating and when updates are available #21836

PR: Only show UpdateManager statusbar widget while updating and when updates are available #21836

Conversation

mrclary commented Feb 27, 2024 • edited by ccordoba12 Loading

Description of Changes

ccordoba12 left a comment

Choose a reason for hiding this comment

ccordoba12 left a comment

Choose a reason for hiding this comment

ccordoba12 commented Apr 9, 2024

mrclary commented Apr 16, 2024

dalthviz commented Apr 16, 2024

dalthviz commented Apr 17, 2024

mrclary commented Apr 17, 2024

mrclary commented Apr 17, 2024

dalthviz left a comment

Choose a reason for hiding this comment

ccordoba12 commented Apr 17, 2024 • edited Loading

ccordoba12 left a comment

Choose a reason for hiding this comment

mrclary commented Feb 27, 2024 •

edited by ccordoba12

Loading

ccordoba12 commented Apr 17, 2024 •

edited

Loading