Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure packaging is included for host #167

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

mrclary
Copy link
Contributor

@mrclary mrclary commented Mar 26, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Using packaging.parse in spyder.__init__ for version normalization requires including packaging in host in order to build the spyder conda package.

See spyder-ide/spyder#21836

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mrclary mrclary changed the title Ensure packing is included for host Ensure packaging is included for host Mar 26, 2024
@ccordoba12
Copy link
Contributor

@mrclary, this is ready to be merged, right?

@mrclary
Copy link
Contributor Author

mrclary commented Apr 9, 2024

@ccordoba12, yes it is ready. Does it need to be re-rendered first? Maybe that's why the Docker build is failing in Azure?

@ccordoba12
Copy link
Contributor

There seems to be a problem with some of the packages used for cross compilation on Linux aarch64.

This is the error:

conda.CondaMultiError: Conda detected a mismatch between the expected content and downloaded content
for url 'https://conda.anaconda.org/conda-forge/noarch/sysroot_linux-aarch64-2.17-h5b4a56d_14.conda'.
  download saved to: /home/conda/feedstock_root/build_artifacts/pkg_cache/sysroot_linux-aarch64-2.17-h5b4a56d_14.conda
  expected sha256: 96e98e80535f177536a9c62886709288afef57ca146d696a4beab6a8c08442b1
  actual sha256: d239232cff55b45a1fbdea9fc660492afca16ba950785d9da3504f16de8fe765

Conda detected a mismatch between the expected content and downloaded content
for url 'https://conda.anaconda.org/conda-forge/noarch/sysroot_linux-aarch64-2.17-h5b4a56d_14.conda'.
  download saved to: /home/conda/feedstock_root/build_artifacts/pkg_cache/sysroot_linux-aarch64-2.17-h5b4a56d_14.conda
  expected sha256: 96e98e80535f177536a9c62886709288afef57ca146d696a4beab6a8c08442b1
  actual sha256: d239232cff55b45a1fbdea9fc660492afca16ba950785d9da3504f16de8fe765

Conda detected a mismatch between the expected content and downloaded content
for url 'https://conda.anaconda.org/conda-forge/noarch/sysroot_linux-64-2.12-he073ed8_17.conda'.
  download saved to: /home/conda/feedstock_root/build_artifacts/pkg_cache/sysroot_linux-64-2.12-he073ed8_17.conda
  expected sha256: e7c68a439924282f3659cfce326c89ce401b09037d561b3c2943d34b0dcb9b3e
  actual sha256: b4e4d685e41cb36cfb16f0cb15d2c61f8f94f56fab38987a44eff95d8a673fb5

Conda detected a mismatch between the expected content and downloaded content
for url 'https://conda.anaconda.org/conda-forge/noarch/libgcc-devel_linux-64-13.2.0-ha9c7c90_105.conda'.
  download saved to: /home/conda/feedstock_root/build_artifacts/pkg_cache/libgcc-devel_linux-64-13.2.0-ha9c7c90_105.conda
  expected sha256: 9adf6a245905be5157ca41e7e2eb259c88535148d1c4cfb487a00a8e17ece127
  actual sha256: 858029ad4d66869c533bb5a22e95e7c044ca66c61d6f403f10d9ae074a0e360e

@conda-forge/core, do you know what's happening here?

@ccordoba12
Copy link
Contributor

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • In conda-forge.yml: $.bot = {'inspection': False}.

    {'inspection': False} is not valid under any of the given schemas

    Schema
    {
      "anyOf": [
        {
          "$ref": "#/$defs/BotConfig"
        },
        {
          "type": "null"
        }
      ]
    }

@ccordoba12
Copy link
Contributor

@mrclary, you were right: it was necessary a rerender to fix that error.

Now, please apply the changes in PR #168 to fix the linter error and do a rerender again (just in case, although I don't think it's necessary).

@mrclary
Copy link
Contributor Author

mrclary commented Apr 11, 2024

@conda-forge-admin, please rerender

Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/spyder-feedstock/actions/runs/8639991247.

@ccordoba12 ccordoba12 marked this pull request as ready for review April 11, 2024 01:25
@ccordoba12 ccordoba12 added the automerge Merge the PR when CI passes label Apr 11, 2024
Copy link
Contributor

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrclary!

@ccordoba12 ccordoba12 changed the title Ensure packaging is included for host Ensure packaging is included for host Apr 11, 2024
@ccordoba12 ccordoba12 merged commit f3769ae into conda-forge:dev Apr 11, 2024
20 checks passed
@mrclary mrclary deleted the normalize-dev-version branch April 11, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants