Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Define Switcher Plugin public API + fix switcher position bug #20837

Merged
merged 19 commits into from
Apr 25, 2023
Merged

PR: Define Switcher Plugin public API + fix switcher position bug #20837

merged 19 commits into from
Apr 25, 2023

Commits on Apr 15, 2023

  1. declare methods that manager calls

    @AngelaRemolina
    AngelaRemolina committed Apr 15, 2023
    Configuration menu
    Copy the full SHA
    e5c0804 View commit details
    Browse the repository at this point in the history

  2. Call methods from QDialog used in manager

    @AngelaRemolina
    AngelaRemolina committed Apr 15, 2023
    Configuration menu
    Copy the full SHA
    a38c1d2 View commit details
    Browse the repository at this point in the history

  3. Move EditorSwitcherManager back to editor utils

    @AngelaRemolina
    AngelaRemolina committed Apr 15, 2023
    Configuration menu
    Copy the full SHA
    5659c41 View commit details
    Browse the repository at this point in the history

  4. Define more methods called in editor manager

    @AngelaRemolina
    AngelaRemolina committed Apr 15, 2023
    Configuration menu
    Copy the full SHA
    157784b View commit details
    Browse the repository at this point in the history

  5. Call plugin instance in editor widget

    @AngelaRemolina
    AngelaRemolina committed Apr 15, 2023
    Configuration menu
    Copy the full SHA
    a468438 View commit details
    Browse the repository at this point in the history

  6. Fix position of switcher in new window

    @AngelaRemolina
    AngelaRemolina committed Apr 15, 2023
    Configuration menu
    Copy the full SHA
    019bbcf View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. Add signals docstrings

    @AngelaRemolina
    AngelaRemolina committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    3f5dfc4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into switcher-public-api

    @AngelaRemolina
    AngelaRemolina authored Apr 17, 2023
    Configuration menu
    Copy the full SHA
    1e020ab View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. add use_switcher flag for testing

    @AngelaRemolina
    AngelaRemolina committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    015f60f View commit details
    Browse the repository at this point in the history

  2. change switcher_dlg attribute name to switcher_plugin

    @AngelaRemolina
    AngelaRemolina committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    3e25c3f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into switcher-public-api

    @AngelaRemolina
    AngelaRemolina authored Apr 18, 2023
    Configuration menu
    Copy the full SHA
    40e5708 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. set switcher flag to false in all tests

    @AngelaRemolina
    AngelaRemolina committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    1814716 View commit details
    Browse the repository at this point in the history

  2. mock switcher in MainWindowMock

    @AngelaRemolina
    AngelaRemolina committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    ae9bf6d View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
    @AngelaRemolina @ccordoba12
    AngelaRemolina and ccordoba12 authored Apr 21, 2023
    Configuration menu
    Copy the full SHA
    37a95c1 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
    @AngelaRemolina @ccordoba12
    AngelaRemolina and ccordoba12 authored Apr 21, 2023
    Configuration menu
    Copy the full SHA
    f668e3b View commit details
    Browse the repository at this point in the history

  3. Add code suggestions

    @AngelaRemolina
    AngelaRemolina committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    8044055 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into switcher-public-api

    @AngelaRemolina
    AngelaRemolina authored Apr 21, 2023
    Configuration menu
    Copy the full SHA
    bb1ee76 View commit details
    Browse the repository at this point in the history

  5. Update switcher tests involving isVisible method

    @AngelaRemolina
    AngelaRemolina committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    095ae77 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2023

  1. Suggestions from review 

    Rename close method to on_close and add open_switcher and open_symbolfinder to the public API
    @AngelaRemolina
    AngelaRemolina committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    0df8d00 View commit details
    Browse the repository at this point in the history