Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Define Switcher Plugin public API + fix switcher position bug #20837

Merged
merged 19 commits into from
Apr 25, 2023

Conversation

AngelaRemolina
Copy link
Contributor

Description of Changes

  • Implemented the plublic API for the Switcher Plugin.
  • Fixed the bug occurring with the position of switcher in an editor new window.
  • Moved back the EditorSwitcherManager from spyder/plugins/switcher/ to spyder/plugins/editor/utils/ and rename it from manager.py to switcher_manager.py
  • Wrote at least one-line docstrings
  • Included a screenshot or animation

switcher_position

Issue(s) Resolved

Continue PR #20714
Necessary to solve #3860

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @angelasofiaremolinagutierrez

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @angelasofiaremolinagutierrez! I left some minor suggestions for you and a couple of questions, the rest looks pretty good to me.

spyder/plugins/editor/widgets/editor.py Show resolved Hide resolved
spyder/plugins/switcher/container.py Show resolved Hide resolved
spyder/plugins/switcher/container.py Outdated Show resolved Hide resolved
spyder/plugins/switcher/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/switcher/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/switcher/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/switcher/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/switcher/widgets/switcher.py Outdated Show resolved Hide resolved
spyder/plugins/switcher/widgets/switcher.py Outdated Show resolved Hide resolved
spyder/plugins/switcher/widgets/switcher.py Outdated Show resolved Hide resolved
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the work here @angelasofiaremolinagutierrez ! Left some comments regarding methods that could be part of the plugin (open_switcher and open_symbolfinder), some info about the on_close method that the plugin or container can implement, and an attribute that seems like could be removed (self._modes at the plugin on_initialize).

If you have any question about the above or something else lets us know!

spyder/app/tests/test_mainwindow.py Outdated Show resolved Hide resolved
spyder/plugins/switcher/plugin.py Outdated Show resolved Hide resolved
spyder/app/tests/conftest.py Outdated Show resolved Hide resolved
Rename close method to on_close and add open_switcher and open_symbolfinder to the public API
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @angelasofiaremolinagutierrez !

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too, thanks @angelasofiaremolinagutierrez!

@ccordoba12 ccordoba12 merged commit 215199d into spyder-ide:master Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants