Skip to content

Enable Enter key submission for One-Time Token login #18824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AnanthaKrishnanJ2001 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −5
Open

Enable Enter key submission for One-Time Token login #18824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...work/security/config/annotation/web/configurers/ott/OneTimeTokenLoginConfigurerTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ void oneTimeTokenWhenConfiguredThenRendersRequestTokenForm() throws Exception {
<input type="text" id="ott-username" name="username" placeholder="Username" required>
</p>
<input name="_csrf" type="hidden" value="%s" />
<button class="primary" type="submit" form="ott-form">Send Token</button>
<button class="primary" type="submit">Send Token</button>
</form>


Expand Down
2 changes: 1 addition & 1 deletion .../org/springframework/security/web/authentication/ui/DefaultLoginPageGeneratingFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,7 @@ private boolean matches(HttpServletRequest request, @Nullable String url) {
{{usernameInput}}
</p>
{{hiddenInputs}}
<button class="primary" type="submit" form="ott-form">Send Token</button>
<button class="primary" type="submit">Send Token</button>
</form>
""";

Expand Down
6 changes: 3 additions & 3 deletions ...rg/springframework/security/web/authentication/DefaultLoginPageGeneratingFilterTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ public void generateWhenOneTimeTokenLoginThenOttForm() throws Exception {
<input type="text" id="ott-username" name="username" placeholder="Username" required>
</p>

<button class="primary" type="submit" form="ott-form">Send Token</button>
<button class="primary" type="submit">Send Token</button>
</form>
""");
}
Expand All @@ -225,7 +225,7 @@ public void generateWhenOneTimeTokenRequestedThenOttForm() throws Exception {
<input type="text" id="ott-username" name="username" placeholder="Username" required>
</p>

<button class="primary" type="submit" form="ott-form">Send Token</button>
<button class="primary" type="submit">Send Token</button>
</form>
""");
assertThat(response.getContentAsString()).doesNotContain("Password");
Expand Down Expand Up @@ -254,7 +254,7 @@ public void generateWhenTwoAuthoritiesRequestedThenBothForms() throws Exception
<input type="text" id="ott-username" name="username" placeholder="Username" required>
</p>

<button class="primary" type="submit" form="ott-form">Send Token</button>
<button class="primary" type="submit">Send Token</button>
</form>
""");
assertThat(response.getContentAsString()).contains("Password");
Expand Down
Loading