Enable Enter key submission for One-Time Token login#18824
Open
AnanthaKrishnanJ2001 wants to merge 1 commit intospring-projects:mainfrom
Open
Enable Enter key submission for One-Time Token login#18824AnanthaKrishnanJ2001 wants to merge 1 commit intospring-projects:mainfrom
AnanthaKrishnanJ2001 wants to merge 1 commit intospring-projects:mainfrom
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
added
type: enhancement
jzheaux
changed the title
AnanthaKrishnanJ2001
force-pushed
the
fix/ott-login-enter-key-submission
branch
from
ceeab3c to
4af211f
Compare
Signed-off-by: Anantha Krishnan <ananthakrishnanj2001@gmail.com>
AnanthaKrishnanJ2001
force-pushed
the
fix/ott-login-enter-key-submission
branch
from
4af211f to
2a23f3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in the default login page where pressing "Enter" in the One-Time Token (OTT) username field would not submit the form. By moving the submit button inside the
<form>tags and removing the redundantformattribute, we restore standard browser submission behavior.Testing
DefaultLoginPageGeneratingFilterTeststo match the corrected HTML structure.Closes #18817