GH-3696: DeserializationEx support for KafkaMS #8689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#3696 * Add an internal logic into `KafkaMessageSource` to react properly for the `ErrorHandlingDeserializer` configuration and re-throw `DeserializationException`
|
In general just copy/pasted the logic from the Thanks |
garyrussell
reviewed
Jul 26, 2023
| } | ||
|
|
||
| @Nullable | ||
| private Object findDeserializerClass(Map<String, Object> props, Properties consumerOverrides, boolean isValue) { |
There was a problem hiding this comment.
I will move most of the duplicated code to SK.ErrorHandlingUtils; then you can use it from there.
There was a problem hiding this comment.
…alizer` from consumer properties
garyrussell
suggested changes
Jul 26, 2023
| @Test | ||
| void deserializationErrorIsThrownFromSource() throws Exception { | ||
| Map<String, Object> consumerProps = KafkaTestUtils.consumerProps(brokers, "testErrorChannelSource", "false"); | ||
| consumerProps.put(ConsumerConfig.AUTO_OFFSET_RESET_CONFIG, "earliest"); |
There was a problem hiding this comment.
FYI, this is now the default in KTU.
| String testData = "test data"; | ||
| template.send(TOPIC2, testData); | ||
|
|
||
| source.receive(); // Trigger Kafka Consumer creation and poll() |
There was a problem hiding this comment.
I am not entirely sure, but the record might be returned by this initial poll.
It would be safer to remove this and move the following assertion into the untilAsserted() -> {...} block.
no reason to wait for assignment or check for returned record. We just need to be sure that `DeserializationException` is thrown eventually
garyrussell
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3696
KafkaMessageSourceto react properly for theErrorHandlingDeserializerconfiguration and re-throwDeserializationException