Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ErrorHandlingDeserializer in KafkaMessageSource #3696

Closed
garyrussell opened this issue Dec 14, 2021 · 0 comments · Fixed by #8689
Closed

Support ErrorHandlingDeserializer in KafkaMessageSource #3696

garyrussell opened this issue Dec 14, 2021 · 0 comments · Fixed by #8689
Assignees
@artembilan
Labels
in: Kafka type: enhancement
Milestone
6.2.0-M2

Comments

@garyrussell
Copy link
Contributor

Expected Behavior

Similar logic to the listener container - send deserialization exceptions to the error channel.

Current Behavior

User has to manually move past the bad record by setting the offset.

Context
@garyrussell garyrussell added this to the Backlog milestone Dec 14, 2021
@artembilan artembilan self-assigned this Jul 25, 2023
@artembilan artembilan modified the milestones: Backlog, 6.2.0-M2 Jul 25, 2023
artembilan added a commit to artembilan/spring-integration that referenced this issue Jul 26, 2023
@artembilan
spring-projectsGH-3696: DeserializationEx support for KafkaMS
2247788 
Fixes spring-projects#3696

* Add an internal logic into `KafkaMessageSource` to react properly for the
`ErrorHandlingDeserializer` configuration and re-throw `DeserializationException`
artembilan added a commit to artembilan/spring-integration that referenced this issue Jul 26, 2023
@artembilan
spring-projectsGH-3696: DeserializationEx support for KafkaMS
eb3e8f6 
Fixes spring-projects#3696

* Add an internal logic into `KafkaMessageSource` to react properly for the
`ErrorHandlingDeserializer` configuration and re-throw `DeserializationException`
@artembilan artembilan mentioned this issue Jul 26, 2023
Merged
garyrussell pushed a commit that referenced this issue Jul 26, 2023
@artembilan
GH-3696: DeserializationEx support for KafkaMS (#8689)
b6d39e4 
* GH-3696: DeserializationEx support for KafkaMS

Fixes #3696

* Add an internal logic into `KafkaMessageSource` to react properly for the
`ErrorHandlingDeserializer` configuration and re-throw `DeserializationException`

* * Use `ErrorHandlingUtils` from `spring-kafka` to determine a `deserializer` from consumer properties

* Revise the test in favor of just single `await().untilAsserted()` -
no reason to wait for assignment or check for returned record.
We just need to be sure that `DeserializationException` is thrown eventually
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artembilan artembilan

Labels
in: Kafka type: enhancement
Projects
None yet
Milestone
6.2.0-M2
Development

Successfully merging a pull request may close this issue.

GH-3696: DeserializationEx support for KafkaMS artembilan/spring-integration
2 participants
@garyrussell @artembilan